From nobody Sun Aug 2 19:55:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hCrC92qjcz4TLmY for ; Sun, 02 Aug 2026 19:55:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hCrC914NPz3cvp for ; Sun, 02 Aug 2026 19:55:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785700549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/qvLzNTlB8B/ouN3vJ9JbgzgGcH1oWG48vpzSpRbtZg=; b=PDcE3BgM3z0VwaM0U4U/+bSAJCbVTScldshDwCjSm6kutfFXjAyYqY/S0rQEkK6NUW4XzK oFYe4l4LFDH2dd45iBYuw7a/s+GcC1l5VLVNae9zj6MqiSJ4veYMVTIlPWYKXX56zmBLLm aBtc1Feqcj/i4jGVHO+oYKCvma0eNuYC2nIxc8Wfja2rJx7cNafg7p1djbi4dSD3cyZ8mO Qu36VzRga4crE6M+ebxIjux1tGSbRvDQQ7XUJrhwhA+AGXE/Zknj1ELi647W7YpDoQsYWs ynkKDzzIN26GMSHqqdRM+ZS9mz0b7dsSpz1Rbg4qJIPqHYAu4flpN0Ydm+jsHA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785700549; a=rsa-sha256; cv=none; b=D/6ipWReN39+rBLBD2nGXYnLGkbnnsK8yvilAMFlejZuYFBNL01zKWvFODJsdZY2+q1Luq HpC/8ibqZtz0TKabrnlpCRUl5+9bEr6JCSqNzznlnk1fm8ULhZCN0vaGEcvbIfIVrapUmk z4ou5NE6Jc4CL5EtNNtNH2TBbGyhQ0lLcjOgf0EM1W2qEZPag6+y70kiHnrrSDdVcXaI5R OjpKf3hOYglQ2+0Tkq2LCCZOrQpL1ZXY8crJYjlnvQIguIEFjJAcoC6gmao0IayyZYY5Hw JfJRli7qC5iEBQsEAxRbFHNdl2HZmQaPDAsLUcbmdZKr1BNo11SKN9dsMYdeQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785700549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/qvLzNTlB8B/ouN3vJ9JbgzgGcH1oWG48vpzSpRbtZg=; b=xYCvoU38BHAaDXymyU3tIzsX8kpJtY4f6JXD3U8Rynn8ragPOSNQoEcPzm+J7V/Hts6pML GaVXg6qPzsbV7tLSzHJ5SMAi9IW+DoSfJ1QmWoVLiD/PATKIk8mEFYAHymCYFU12SMRVkM NOqGGm89QSRmnTJbPicbm+9jMVyYEzwX3fgfR+myIRntISrqgiBJk675OSmdwsFV6+8yzs a8TQMEGsXmc/cAh0tJVd15BdHBuyVXhnVk+U2o0o8EDKVkJTME2av+a5zolGno0HI3cXG7 o81urU95fL7ndyrSugJwpK7c3F2CCWSmBllp1YTRbx9URQCMrTpSSUv1ro3+pg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hCrC871XgzD5S for ; Sun, 02 Aug 2026 19:55:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27fe8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 02 Aug 2026 19:55:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Mark Johnston From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: b56bd4c44494 - stable/14 - libfetch: Fix handling of connection failures List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b56bd4c444948f6e353c489cf4f17e0c05dbd46b Auto-Submitted: auto-generated Date: Sun, 02 Aug 2026 19:55:48 +0000 Message-Id: <6a6fa0c4.27fe8.32d7f07f@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=b56bd4c444948f6e353c489cf4f17e0c05dbd46b commit b56bd4c444948f6e353c489cf4f17e0c05dbd46b Author: Mark Johnston AuthorDate: 2026-07-27 18:58:34 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-08-02 19:55:00 +0000 libfetch: Fix handling of connection failures After commit 848f360c8f9a, if one tries to connect to a closed port, fetch reports "Operation now in progress", which is rather confusing. Return a more useful error message, restoring the old behaviour. Fixes: 848f360c8f9a ("libfetch: Apply timeout to connection attempts") Reviewed by: des MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D58481 (cherry picked from commit b02e02958dad2d5ce3675cbc18b9a94635d09e66) --- lib/libfetch/common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/libfetch/common.c b/lib/libfetch/common.c index 31b4997780b2..accb6bec6124 100644 --- a/lib/libfetch/common.c +++ b/lib/libfetch/common.c @@ -682,6 +682,10 @@ fetch_connect(const char *host, int port, int af, int verbose) delta.tv_usec / 1000; } } + if (pfd.revents & POLLHUP) { + errno = ECONNREFUSED; + break; + } if (pfd.revents == POLLOUT) { /* connection established */ err = 0;