From owner-freebsd-fs@FreeBSD.ORG Fri Apr 5 16:29:18 2013 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E76F937D; Fri, 5 Apr 2013 16:29:18 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from mail.vx.sk (mail.vx.sk [IPv6:2a01:4f8:150:6101::4]) by mx1.freebsd.org (Postfix) with ESMTP id A991E197; Fri, 5 Apr 2013 16:29:18 +0000 (UTC) Received: from core.vx.sk (localhost [127.0.0.2]) by mail.vx.sk (Postfix) with ESMTP id 37F3D36296; Fri, 5 Apr 2013 18:29:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at mail.vx.sk Received: from mail.vx.sk by core.vx.sk (amavisd-new, unix socket) with LMTP id R7eDwxJXQqov; Fri, 5 Apr 2013 18:29:13 +0200 (CEST) Received: from [10.9.8.1] (chello085216226145.chello.sk [85.216.226.145]) by mail.vx.sk (Postfix) with ESMTPSA id 3FA9B36284; Fri, 5 Apr 2013 18:29:11 +0200 (CEST) Message-ID: <515EFBD8.50900@FreeBSD.org> Date: Fri, 05 Apr 2013 18:29:12 +0200 From: Martin Matuska User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Larry Rosenman Subject: Re: [CRASH] ZFS recv (fwd)/CURRENT References: <5159EF29.6000503@FreeBSD.org> <515B4CFA.9080706@FreeBSD.org> <9bc083a21a73839a0932514ea4f48d0d@webmail.lerctr.org> In-Reply-To: <9bc083a21a73839a0932514ea4f48d0d@webmail.lerctr.org> X-Enigmail-Version: 1.5.1 Content-Type: multipart/mixed; boundary="------------030409060808020909030202" Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2013 16:29:19 -0000 This is a multi-part message in MIME format. --------------030409060808020909030202 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit You can use the attached patch, it should fix the problem. We are still waiting for code review and a final solution by illumos, maybe I will commit this preliminary (or final) fix to head. mm On 5.4.2013 16:49, Larry Rosenman wrote: > On 2013-04-02 16:26, Martin Matuska wrote: >> On 1. 4. 2013 22:33, Martin Matuska wrote: >>> This error seems to be limited to sending deduplicated streams. Does >>> sending without "-D" work ok? This might be a vendor error as well. >>> >>> On 1.4.2013 20:05, Larry Rosenman wrote: >>>> Re-Sending. Any ideas, guys/gals? >>>> >>>> This really gets in my way. >>>> >> This may be also related to: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=176978 > Taking off -D does get around the panic. > > What information can I provide to help fix it? > > I *CAN* provide access to both sides via SSH. > > -- Martin Matuska FreeBSD committer http://blog.vx.sk --------------030409060808020909030202 Content-Type: text/plain; charset=windows-1250; name="dmu_send.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="dmu_send.c.patch" Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c =================================================================== --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c (revision 249165) +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c (working copy) @@ -990,6 +990,7 @@ free_guid_map_onexit(void *arg) while ((gmep = avl_destroy_nodes(ca, &cookie)) != NULL) { dsl_dataset_long_rele(gmep->gme_ds, gmep); + dsl_dataset_rele(gmep->gme_ds, FTAG); kmem_free(gmep, sizeof (guid_map_entry_t)); } avl_destroy(ca); @@ -1698,7 +1699,6 @@ add_ds_to_guidmap(const char *name, avl_tree_t *gu gmep->gme_ds = snapds; avl_add(guid_map, gmep); dsl_dataset_long_hold(snapds, gmep); - dsl_dataset_rele(snapds, FTAG); } dsl_pool_rele(dp, FTAG); --------------030409060808020909030202--