From owner-cvs-all@FreeBSD.ORG Tue Aug 23 02:19:20 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 06B5B1065673; Tue, 23 Aug 2011 02:19:20 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 9931914F9CF; Tue, 23 Aug 2011 02:19:18 +0000 (UTC) Message-ID: <4E530E26.2090603@FreeBSD.org> Date: Mon, 22 Aug 2011 19:19:18 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:6.0) Gecko/20110819 Thunderbird/6.0 MIME-Version: 1.0 To: Alexey Dokuchaev References: <201108221821.p7MILBln038468@repoman.freebsd.org> <20110823020838.GA96726@FreeBSD.org> In-Reply-To: <20110823020838.GA96726@FreeBSD.org> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pawel Pekala Subject: Re: cvs commit: ports/polish/kadu Makefile distinfo pkg-descr pkg-plist ports/polish/kadu/files patch-kadu-core__CMakeLists.txt patch-kadu-core_gadu_resolver.cpp patch-modules__docking__CMakeLists.txt patch-modules__idle__CMakeLists.txt patch-modules__kde_notify__CMakeLists.txt patch-modules__screenshot__CMakeLists.txt patch-modules__sound__CMakeLists.txt ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2011 02:19:20 -0000 On 08/22/2011 19:08, Alexey Dokuchaev wrote: > On Mon, Aug 22, 2011 at 06:21:11PM +0000, Pawel Pekala wrote: >> pawel 2011-08-22 18:21:11 UTC >> >> Log: >> - unbreak and update to version 0.9.2 >> - add LICENSE info >> - mark MAKE_JOBS_UNSAFE >> - remove WITH_TABS option, now included in main package >> - take maintainership > > Still some issues with this port: > > - First part of the makefile (delarative one) is badly indented; indentation > should be reduced my one tabstop > > - Bad spelling of Qt toolkit in COMMENT (it looks like port is QuickTime > based now); also, " / " does not look too good, simple "and" would look > better > > %%% > LIB_DEPENDS= enchant.1:${PORTSDIR}/textproc/enchant \ > gadu.3:${PORTSDIR}/polish/libgadu \ > + idn:${PORTSDIR}/dns/libidn \ > qca.2:${PORTSDIR}/devel/qca \ > sndfile.1:${PORTSDIR}/audio/libsndfile > %%% > > Missing shlib version (notice that other libs have it). While it > technically not required, it's nice to have to be able to grep for when > buming port revision of library consumer ports to chase shlib version > bumps. The version should only be specified for dependents that are tied to a specific version. If the dependent can survive a version bump of the lib then the dependency should be specified without version, and NOT bumped when the lib is updated. Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/