From owner-svn-src-all@freebsd.org Sun Feb 10 07:50:38 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07BB814E381F; Sun, 10 Feb 2019 07:50:38 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f194.google.com (mail-it1-f194.google.com [209.85.166.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C2FA76B23E; Sun, 10 Feb 2019 07:50:36 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f194.google.com with SMTP id i145so19086441ita.4; Sat, 09 Feb 2019 23:50:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=aoGkjPECTapsimFTH4Faq6UkLCFEpcdN7qPO3OGUHBM=; b=ZqtztxC87ryJHjCw8Zt1FQOFq5PoGMvtzvtJig0hvxPP7LAFpm2md9rzQrNcPDO+un e9pWBRRz/AoVPiiEhLeZR16vTOnz6NnAhchSDt0eDCTY9xQNvwdTwFWL8A3V8eEc2wex G2sgyiWPIS72LskfD5uLsVMiMjV/v4bluWSDuPXNcbvI9mViVx8KmaqnM+DrVBgSJTlu GLBlarP0bXkpbzW9MKlJ+TMM4YKZsdkxF/Sg//ZprjjhZFafHe/v0DLij9ASTfuqz7b5 C0ge0/katgA+ubjiUuj9li59LCTHQ+Id4ubaO9uW18eo67xPyPI74f8qfo8IlEdkb1yZ eK0Q== X-Gm-Message-State: AHQUAubAXwiv/+OYrKYw9u/VFG5Zb3Jmo72HDT/vt+bhEYbtBy9hq6pr TuXE3TIFfKPtvRjWoYrAVP+vLvHW X-Google-Smtp-Source: AHgI3IZR/ImzkhgCFvvXo3QyetKK6AeGWSK3126n6SI17YlrQcWo2tX985avyjIBsM6/DqBsAD8LTQ== X-Received: by 2002:a24:59ca:: with SMTP id p193mr3367432itb.63.1549785029979; Sat, 09 Feb 2019 23:50:29 -0800 (PST) Received: from mail-it1-f180.google.com (mail-it1-f180.google.com. [209.85.166.180]) by smtp.gmail.com with ESMTPSA id c31sm3557751itd.25.2019.02.09.23.50.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Feb 2019 23:50:29 -0800 (PST) Received: by mail-it1-f180.google.com with SMTP id x124so12869223itd.1; Sat, 09 Feb 2019 23:50:29 -0800 (PST) X-Received: by 2002:a5d:8610:: with SMTP id f16mr551587iol.233.1549785029108; Sat, 09 Feb 2019 23:50:29 -0800 (PST) MIME-Version: 1.0 References: <201902041655.x14GtOIr046072@repo.freebsd.org> In-Reply-To: <201902041655.x14GtOIr046072@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 9 Feb 2019 23:50:18 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r343746 - head/sys/conf To: Andrew Turner Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C2FA76B23E X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.194 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.68)[-0.685,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-1.31)[ip: (-0.74), ipnet: 209.85.128.0/17(-3.78), asn: 15169(-1.95), country: US(-0.07)]; RCVD_IN_DNSWL_NONE(0.00)[194.166.85.209.list.dnswl.org : 127.0.5.0]; RWL_MAILSPIKE_POSSIBLE(0.00)[194.166.85.209.rep.mailspike.net : 127.0.0.17] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Feb 2019 07:50:38 -0000 Hi Andrew, This makes it compile, but instead of a build failure the kernel is broken hard at runtime in early boot with GCC < 8.1. E.g., amd64-xtoolchain-gcc standard cross-toolchain is still on GCC 6.4.0. HEAD GENERIC has been broken in one form or another for xtoolchain GCC since r343713 (Feb 3), so I'm going to go ahead and turn this option off in GENERIC. Feel free to reenable when you've tested that it works. Best, Conrad On Mon, Feb 4, 2019 at 8:55 AM Andrew Turner wrote: > > Author: andrew > Date: Mon Feb 4 16:55:24 2019 > New Revision: 343746 > URL: https://svnweb.freebsd.org/changeset/base/343746 > > Log: > Only enable trace-cmp on Clang and modern GCC. > > It's was only added to GCC 8.1 so don't try to enable it for earlier > releases. > > Reported by: lwhsu > Sponsored by: DARPA, AFRL > > Modified: > head/sys/conf/files > head/sys/conf/kern.pre.mk > > Modified: head/sys/conf/files > ============================================================================== > --- head/sys/conf/files Mon Feb 4 16:13:41 2019 (r343745) > +++ head/sys/conf/files Mon Feb 4 16:55:24 2019 (r343746) > @@ -3808,7 +3808,7 @@ kern/kern_idle.c standard > kern/kern_intr.c standard > kern/kern_jail.c standard > kern/kern_kcov.c optional kcov \ > - compile-with "${NORMAL_C} -fno-sanitize-coverage=trace-pc,trace-cmp" > + compile-with "${NORMAL_C} -fno-sanitize=all" > kern/kern_khelp.c standard > kern/kern_kthread.c standard > kern/kern_ktr.c optional ktr > > Modified: head/sys/conf/kern.pre.mk > ============================================================================== > --- head/sys/conf/kern.pre.mk Mon Feb 4 16:13:41 2019 (r343745) > +++ head/sys/conf/kern.pre.mk Mon Feb 4 16:55:24 2019 (r343746) > @@ -120,7 +120,12 @@ SAN_CFLAGS+= -fsanitize=undefined > > COVERAGE_ENABLED!= grep COVERAGE opt_global.h || true ; echo > .if !empty(COVERAGE_ENABLED) > +.if ${COMPILER_TYPE} == "clang" || \ > + (${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 80100) > SAN_CFLAGS+= -fsanitize-coverage=trace-pc,trace-cmp > +.else > +SAN_CFLAGS+= -fsanitize-coverage=trace-pc > +.endif > .endif > > CFLAGS+= ${SAN_CFLAGS} >