From owner-svn-ports-head@freebsd.org Sat Mar 20 10:18:26 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1037157AE14; Sat, 20 Mar 2021 10:18:26 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F2cD12Kz3z3nQT; Sat, 20 Mar 2021 10:18:25 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: by mail-lf1-f46.google.com with SMTP id a198so13858858lfd.7; Sat, 20 Mar 2021 03:18:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=znrDy/jjU01v2d7EsoN2BjjUbyLJQljzOWpFEuke6xU=; b=iQdX/Q9LMroWplnAAA3zBBgZ118z6Hy7HrSCAJWYWUjC1gufRo6VAQGPEmhNsrCphu s18DkbigXbkYcEbPESpXtGqoFXVAk3RJgbEBYAk9o+cZPZjrWAwOt6unpIK0iJf4Nzbq 3hgTQwqeq1/f9Wf1XaDWvMOraFw+PNhqOaZP2IvnuvdhLdaBjZQU6vtn/MmR2AENfqF8 Hc9TdD7AoHpnalqLFbe5sokY3CZiUEJbIfE47xSd9qfKWQ490ms6FzjhXL5vl3Uv8WJm ymbmwSefU/N0L1E29AC+pZpGpu+mOrZzrLQa/vYg8ZbtGHRnyyiYj4t204ZpQMkbma3g uHOQ== X-Gm-Message-State: AOAM531hqnwIflZCE3DONjOsLXVRGsB3totqiq88j8IW4DrffBO/n9p8 0WtCDL5B17b7FHWij7rge20MujAIh71+Sg== X-Google-Smtp-Source: ABdhPJzeHTq0zM4KeQnSjlPdiFEj8RxNWkOE37MlLoKJaq1CsXtyjZIlkeKft5qv2nuV7mhl4HFaFQ== X-Received: by 2002:a19:c309:: with SMTP id t9mr3258920lff.348.1616235503819; Sat, 20 Mar 2021 03:18:23 -0700 (PDT) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id k6sm902602lfm.19.2021.03.20.03.18.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Mar 2021 03:18:23 -0700 (PDT) Received: by mail-lf1-f50.google.com with SMTP id x28so13854782lfu.6; Sat, 20 Mar 2021 03:18:23 -0700 (PDT) X-Received: by 2002:a19:4cc1:: with SMTP id z184mr3244627lfa.599.1616235503474; Sat, 20 Mar 2021 03:18:23 -0700 (PDT) MIME-Version: 1.0 References: <202103191336.12JDaj8i012572@repo.freebsd.org> <20210319174447.GA16542@FreeBSD.org> <20210320033712.GA18472@FreeBSD.org> <20210320081832.GA21788@FreeBSD.org> In-Reply-To: <20210320081832.GA21788@FreeBSD.org> From: Gleb Popov Date: Sat, 20 Mar 2021 13:17:58 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r568794 - in head/multimedia/pipewire: . files To: Alexey Dokuchaev Cc: ports-committers , svn-ports-all , svn-ports-head X-Rspamd-Queue-Id: 4F2cD12Kz3z3nQT X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of 6yearold@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=6yearold@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.167.46:from]; SPAMHAUS_ZRD(0.00)[209.85.167.46:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; TO_DN_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.46:from]; FORGED_SENDER(0.30)[arrowd@freebsd.org,6yearold@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.46:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[arrowd@freebsd.org,6yearold@gmail.com]; MAILMAN_DEST(0.00)[svn-ports-all,svn-ports-head] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Mar 2021 10:18:26 -0000 On Sat, Mar 20, 2021 at 11:18 AM Alexey Dokuchaev wrote: > On Sat, Mar 20, 2021 at 10:38:30AM +0300, Gleb Popov wrote: > > On Sat, Mar 20, 2021 at 6:37 AM Alexey Dokuchaev > wrote: > > ... > > > On Fri, Mar 19, 2021 at 10:16:35PM +0300, Gleb Popov wrote: > > > > Exactly this. > > > > > > Understood. Please try to write more elaborate commit logs next time, > > > so everyone could easily see what's going on, not just you or me. > > > > I clearly remember the case where you criticized a committer for a too > > lengthy commit message. I'll try my best next time, anyways. > > That doesn't sound like me at all, I love elaborate commit messages (as > long as they are of why-ish, not what-ish type and not merely translate > the commit diff in English). I'll have to dig into my sent-mail to see > what were the circumstances in that particular case. > IIRC, the commit I was talking about had a Changelog in its description. > > P.S. With all these "do the repocopy!" and "bad commit message!" you're > > really living up to your surname. No offence, just joking. > > I don't understand. There are certain bylaws and even rules of how we do > things in the common repo, those practices are instated to make everyone's > work easier. Waived repocopies and poor commit logs make this harder. > > And I'm not just complaining, I actually go and fix the mess when I see > there's no interest from the original committer. Did I ever get a "thank > you" back? No, I got "you're really living up to your surname" from you. > >From me? Well, it is pretty expectable. I never found myself in a situation when I needed to follow all these repocopies. Why should I be grateful for something not useful for me? To the contrary, I actually do repocopies when required (including when requested by you) and this only adds more work for me. I have to remember the command every time. Trying to be a good developer I'm following the rule, but the rule itself doesn't pay off for me. Everything you say is correct in general, but I'm still having hard times applying it to concrete cases. Speaking of this commit, I don't understand who would ever (except you) want to dig into to figure out a rationale for this patch. It will be gone in the next port update anyways. Until I figure that, I'm afraid I'll keep making these mistakes.