From owner-svn-src-stable-8@FreeBSD.ORG Thu Oct 27 14:11:19 2011 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3C4C1065676; Thu, 27 Oct 2011 14:11:19 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id A2EEA8FC16; Thu, 27 Oct 2011 14:11:19 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p9REBJcG010137; Thu, 27 Oct 2011 14:11:19 GMT (envelope-from kib@svn.freebsd.org) Received: (from kib@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id p9REBJQQ010134; Thu, 27 Oct 2011 14:11:19 GMT (envelope-from kib@svn.freebsd.org) Message-Id: <201110271411.p9REBJQQ010134@svn.freebsd.org> From: Konstantin Belousov Date: Thu, 27 Oct 2011 14:11:19 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r226838 - stable/8/contrib/csup X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2011 14:11:19 -0000 Author: kib Date: Thu Oct 27 14:11:19 2011 New Revision: 226838 URL: http://svn.freebsd.org/changeset/base/226838 Log: MFC r225979: Update the comment. MFC r225980: Handle the situation where fixups_close() has been called but more fixups are still available on the queue. Modified: stable/8/contrib/csup/fixups.c stable/8/contrib/csup/updater.c Directory Properties: stable/8/contrib/csup/ (props changed) Modified: stable/8/contrib/csup/fixups.c ============================================================================== --- stable/8/contrib/csup/fixups.c Thu Oct 27 14:07:57 2011 (r226837) +++ stable/8/contrib/csup/fixups.c Thu Oct 27 14:11:19 2011 (r226838) @@ -141,7 +141,7 @@ fixups_get(struct fixups *f) fixups_lock(f); while (f->size == 0 && !f->closed) pthread_cond_wait(&f->cond, &f->lock); - if (f->closed) { + if (f->closed && f->size == 0) { fixups_unlock(f); return (NULL); } Modified: stable/8/contrib/csup/updater.c ============================================================================== --- stable/8/contrib/csup/updater.c Thu Oct 27 14:07:57 2011 (r226837) +++ stable/8/contrib/csup/updater.c Thu Oct 27 14:11:19 2011 (r226838) @@ -238,7 +238,7 @@ updater(void *arg) /* * Make sure to close the fixups even in case of an error, - * so that the lister thread doesn't block indefinitely. + * so that the detailer thread doesn't block indefinitely. */ fixups_close(up->config->fixups); if (!error)