From owner-freebsd-bugs@FreeBSD.ORG Sun Aug 7 05:30:19 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFB2916A41F for ; Sun, 7 Aug 2005 05:30:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D466F43D49 for ; Sun, 7 Aug 2005 05:30:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j775UI4s073544 for ; Sun, 7 Aug 2005 05:30:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j775UIvI073543; Sun, 7 Aug 2005 05:30:18 GMT (envelope-from gnats) Resent-Date: Sun, 7 Aug 2005 05:30:18 GMT Resent-Message-Id: <200508070530.j775UIvI073543@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stanislav Sedov Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A41B916A41F for ; Sun, 7 Aug 2005 05:28:50 +0000 (GMT) (envelope-from stas@dracon.310.ru) Received: from dracon.310.ru (dracon.310.ru [83.97.105.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0BE3B43D49 for ; Sun, 7 Aug 2005 05:28:49 +0000 (GMT) (envelope-from stas@dracon.310.ru) Received: from dracon.310.ru (localhost.310.ru [127.0.0.1]) by dracon.310.ru (8.13.3/8.13.1) with ESMTP id j775SmpP052459 for ; Sun, 7 Aug 2005 09:28:48 +0400 (MSD) (envelope-from stas@dracon.310.ru) Received: (from stas@localhost) by dracon.310.ru (8.13.3/8.13.1/Submit) id j775Sh7q052458; Sun, 7 Aug 2005 09:28:43 +0400 (MSD) (envelope-from stas) Message-Id: <200508070528.j775Sh7q052458@dracon.310.ru> Date: Sun, 7 Aug 2005 09:28:43 +0400 (MSD) From: Stanislav Sedov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/84637: GEOM LABEL sometimes doesn't recognize labels on UFS1 parts X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Stanislav Sedov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Aug 2005 05:30:20 -0000 >Number: 84637 >Category: kern >Synopsis: GEOM LABEL sometimes doesn't recognize labels on UFS1 parts >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 07 05:30:18 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Stanislav Sedov >Release: FreeBSD 7.0-CURRENT i386 >Organization: 310.ru [Tridesyatoe] >Environment: System: FreeBSD stalingrad.realnet 7.0-CURRENT FreeBSD 7.0-CURRENT #96: Thu Jul 28 21:05:39 UTC 2005 root@stalingrad.realnet:/work/src/fbsd-cur/src/sys/i386/compile/DESKTOP i386 >Description: GEOM label class doesn't recognize labels on UFS partitions where mediasize % fragsize != 0. >How-To-Repeat: >Fix: --- g_label_ufs.c.diff begins here --- --- g_label_ufs.c.orig Mon Jul 25 13:42:13 2005 +++ g_label_ufs.c Mon Jul 25 13:33:29 2005 @@ -78,8 +78,8 @@ if (fs->fs_magic == FS_UFS1_MAGIC) { G_LABEL_DEBUG(1, "UFS1 file system detected on %s.", pp->name); - if (fs->fs_old_size * fs->fs_fsize != - (int32_t)pp->mediasize) { + if (fs->fs_fsize <= 0 || + pp->mediasize / fs->fs_fsize != fs->fs_old_size) { G_LABEL_DEBUG(1, "Incorrect superblock " \ "parameters on %s.", pp->name); g_free(fs); @@ -90,6 +90,8 @@ pp->name); if (fs->fs_fsize <= 0 || pp->mediasize / fs->fs_fsize != fs->fs_size) { + G_LABEL_DEBUG(1, "Incorrect superblock " \ + "parameters on %s.", pp->name); g_free(fs); continue; } --- g_label_ufs.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: