From owner-svn-soc-all@FreeBSD.ORG  Sun Sep  1 20:50:13 2013
Return-Path: <owner-svn-soc-all@FreeBSD.ORG>
Delivered-To: svn-soc-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 751BBB62
 for <svn-soc-all@FreeBSD.org>; Sun,  1 Sep 2013 20:50:13 +0000 (UTC)
 (envelope-from mattbw@FreeBSD.org)
Received: from socsvn.freebsd.org (socsvn.freebsd.org
 [IPv6:2001:1900:2254:206a::50:2])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 47FFE24ED
 for <svn-soc-all@FreeBSD.org>; Sun,  1 Sep 2013 20:50:13 +0000 (UTC)
Received: from socsvn.freebsd.org ([127.0.1.124])
 by socsvn.freebsd.org (8.14.7/8.14.7) with ESMTP id r81KoDiC032412
 for <svn-soc-all@FreeBSD.org>; Sun, 1 Sep 2013 20:50:13 GMT
 (envelope-from mattbw@FreeBSD.org)
Received: (from www@localhost)
 by socsvn.freebsd.org (8.14.7/8.14.6/Submit) id r81KoDTB032393
 for svn-soc-all@FreeBSD.org; Sun, 1 Sep 2013 20:50:13 GMT
 (envelope-from mattbw@FreeBSD.org)
Date: Sun, 1 Sep 2013 20:50:13 GMT
Message-Id: <201309012050.r81KoDTB032393@socsvn.freebsd.org>
X-Authentication-Warning: socsvn.freebsd.org: www set sender to
 mattbw@FreeBSD.org using -f
From: mattbw@FreeBSD.org
To: svn-soc-all@FreeBSD.org
Subject: socsvn commit: r256808 - soc2013/mattbw/backend
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-soc-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the entire Summer of Code repository
 <svn-soc-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-soc-all>
List-Post: <mailto:svn-soc-all@freebsd.org>
List-Help: <mailto:svn-soc-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Sep 2013 20:50:13 -0000

Author: mattbw
Date: Sun Sep  1 20:50:12 2013
New Revision: 256808
URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=256808

Log:
  Add namever unit tests.
  
  Not much to report here, just some more unit tests.
  

Modified:
  soc2013/mattbw/backend/Atffile
  soc2013/mattbw/backend/Makefile
  soc2013/mattbw/backend/namever.c
  soc2013/mattbw/backend/namever.h

Modified: soc2013/mattbw/backend/Atffile
==============================================================================
--- soc2013/mattbw/backend/Atffile	Sun Sep  1 19:59:54 2013	(r256807)
+++ soc2013/mattbw/backend/Atffile	Sun Sep  1 20:50:12 2013	(r256808)
@@ -2,4 +2,5 @@
 
 prop: test-suite = "main"
 
+tp: namever_test
 tp: pkgutils_test

Modified: soc2013/mattbw/backend/Makefile
==============================================================================
--- soc2013/mattbw/backend/Makefile	Sun Sep  1 19:59:54 2013	(r256807)
+++ soc2013/mattbw/backend/Makefile	Sun Sep  1 20:50:12 2013	(r256808)
@@ -71,6 +71,7 @@
 
 # ATF test flags
 TESTPROGS=					\
+		namever_test			\
 		pkgutils_test			\
 		query/id_test			\
 		query/check_test		\
@@ -118,5 +119,10 @@
 pkgutils_test.o: pkgutils_test.c
 	${CC} ${CFLAGS} ${TESTCFLAGS} -o ${.TARGET} -c ${.ALLSRC}
 
+namever_test: namever_test.o namever.o
+	${CC} ${LDFLAGS} ${TESTLDFLAGS} -o ${.TARGET} ${.ALLSRC} ${LIBS} ${TESTLIBS}
+
+namever_test.o: namever_test.c
+	${CC} ${CFLAGS} ${TESTCFLAGS} -o ${.TARGET} -c ${.ALLSRC}
 
 .include <bsd.lib.mk>

Modified: soc2013/mattbw/backend/namever.c
==============================================================================
--- soc2013/mattbw/backend/namever.c	Sun Sep  1 19:59:54 2013	(r256807)
+++ soc2013/mattbw/backend/namever.c	Sun Sep  1 20:50:12 2013	(r256808)
@@ -74,7 +74,7 @@
  * To be freed using free(3).
  */
 char	       *
-namever_from_package_id(gchar *package_id)
+namever_from_package_id(const gchar *package_id)
 {
 	char	       *result;
 	gchar	      **id_splits;

Modified: soc2013/mattbw/backend/namever.h
==============================================================================
--- soc2013/mattbw/backend/namever.h	Sun Sep  1 19:59:54 2013	(r256807)
+++ soc2013/mattbw/backend/namever.h	Sun Sep  1 20:50:12 2013	(r256808)
@@ -21,9 +21,12 @@
 #ifndef _PKGNG_BACKEND_NAMEVER_H_
 #define _PKGNG_BACKEND_NAMEVER_H_
 
+#include <glib.h>		/* gchar, guint */
+#include "pkg.h"		/* struct pkg */
+
 char	       *namever_from_name_and_version(const char *name, const char *version);
 char	       *namever_from_package(struct pkg *package);
-char	       *namever_from_package_id(gchar *package_id);
+char	       *namever_from_package_id(const gchar *package_id);
 char	      **namever_array_from_package_ids(gchar **package_ids, guint count);
 void		namever_array_free(char ***namevers_p, guint count);
 #endif				/* !_PKGNG_BACKEND_NAMEVER_H_ */