From owner-freebsd-dtrace@FreeBSD.ORG  Thu May 30 13:56:21 2013
Return-Path: <owner-freebsd-dtrace@FreeBSD.ORG>
Delivered-To: freebsd-dtrace@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id E441648C;
 Thu, 30 May 2013 13:56:21 +0000 (UTC)
 (envelope-from markjdb@gmail.com)
Received: from mail-ob0-x232.google.com (mail-ob0-x232.google.com
 [IPv6:2607:f8b0:4003:c01::232])
 by mx1.freebsd.org (Postfix) with ESMTP id 95C2F36F;
 Thu, 30 May 2013 13:56:21 +0000 (UTC)
Received: by mail-ob0-f178.google.com with SMTP id fb19so609704obc.9
 for <multiple recipients>; Thu, 30 May 2013 06:56:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=PAal6V3NcF3Y+kqlQ7BdRgum6d8k4PIJlT/LQVf4eAY=;
 b=ayt6blshIewwgOJrpP+nqNP8gx/Hw1mr46I3oWQQfBUUDVdeptNC8D+3sRokKYAEBY
 SZMI6wOyIHv9VI0lQkmFmPJ/a7v6IxgHCvB8i6BkqR64P0cG7bwX+LY6+0S2XScw02ss
 88WwYuGR5HlWDDgt7sZ/N+U2Om8B7Mch0l4Po6pFjp/mIMm++yXF2Zl22TyrHyOaAyNA
 5N/fswP/myvljJJocTT0IAVyI/ZKWiU4DBO0HBy3DiNLVDuWYYF2JAWiqyWfq5ot7W7C
 +Oi/266nwiCQfbQLok0nqsASUNz4g5O3AUiVI9eS7EO7K4yuOiIGCvV3J4zGbvNu0p85
 g5Qw==
X-Received: by 10.60.79.231 with SMTP id m7mr4241994oex.105.1369922181221;
 Thu, 30 May 2013 06:56:21 -0700 (PDT)
Received: from gloom.sandvine.com ([64.7.137.182])
 by mx.google.com with ESMTPSA id jt1sm44045744oeb.5.2013.05.30.06.56.19
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Thu, 30 May 2013 06:56:20 -0700 (PDT)
Sender: Mark Johnston <markjdb@gmail.com>
Date: Thu, 30 May 2013 09:56:14 -0400
From: Mark Johnston <markj@freebsd.org>
To: George Neville-Neil <gnn@freebsd.org>
Subject: Re: adding SDT probe functions with 6+ DTrace arguments
Message-ID: <20130530135601.GA1631@gloom.sandvine.com>
References: <20130530040705.GA40320@gloom>
 <CALWP=0aRG5zjcNBJsgA0gwp9x8J_gxEtagfVy3JfK2ePC0J0jA@mail.gmail.com>
 <CA+XzFFjOE7y4QueSuqw8zcWMWk7pVyGKifZwgbZcANXYpKrVyA@mail.gmail.com>
 <9900CFFB-6E68-4034-805A-859A937179EF@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9900CFFB-6E68-4034-805A-859A937179EF@freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: rstone@freebsd.org, freebsd-dtrace@freebsd.org
X-BeenThere: freebsd-dtrace@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "A discussion list for developers working on DTrace in FreeBSD."
 <freebsd-dtrace.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-dtrace>, 
 <mailto:freebsd-dtrace-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-dtrace>
List-Post: <mailto:freebsd-dtrace@freebsd.org>
List-Help: <mailto:freebsd-dtrace-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-dtrace>,
 <mailto:freebsd-dtrace-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 May 2013 13:56:22 -0000

On Thu, May 30, 2013 at 09:02:54AM -0400, George Neville-Neil wrote:
> 
> On May 30, 2013, at 2:14 , Brendan Gregg <brendan.gregg@joyent.com> wrote:
> 
> > G'Day Mark,
> > 
> > As this might be interesting: to check that DTRACE_PROBE7 worked, in
> > Solaris I had added an sdt:::test probe, which could be invoked by the
> > DTrace test suite (sdt/tst.sdtargs.c) by calling uadmin() with A_SDTTEST:
> > 
> >        case A_SDTTEST:
> >        {
> >                DTRACE_PROBE7(test, int, 1, int, 2, int, 3, int, 4, int, 5,
> >                    int, 6, int, 7);
> >                break;
> >        }
> > 
> > Getting the tcp and ip providers working will be great.
> > 
> 
> Chiming in late.  Yes, let's extend the SDT macros in line with what we've done
> already.  This will also make it easy to MFC to 9 and 8.

Ok, thanks. I'll commit them later today. The network providers depend
on them, so I wanted to get them in first as well as fix the bugs
mentioned in my other email on this thread.

-Mark