From owner-cvs-all@FreeBSD.ORG Sun Feb 27 06:33:47 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 00155106566C; Sun, 27 Feb 2011 06:33:46 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from doug-optiplex.ka9q.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 967AD14DC3F; Sun, 27 Feb 2011 06:33:46 +0000 (UTC) Message-ID: <4D69F04A.8070502@FreeBSD.org> Date: Sat, 26 Feb 2011 22:33:46 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20110129 Thunderbird/3.1.7 MIME-Version: 1.0 To: Xin LI References: <201102260458.p1Q4wb0E027989@repoman.freebsd.org> In-Reply-To: <201102260458.p1Q4wb0E027989@repoman.freebsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: multipart/mixed; boundary="------------040001030900070403020102" Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net Makefile ports/net/iet Makefile distinfo pkg-descr pkg-plist ports/net/iet/files ietd.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Feb 2011 06:33:47 -0000 This is a multi-part message in MIME format. --------------040001030900070403020102 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit There are numerous problems with the rc.d script in this port. Please see http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for more information. The biggest problem (that must be fixed, along with a PORTREVISION bump) is that it doesn't have a default value for _enable. The other problems are that it's not clear why REQUIRE and BEFORE are set the way they are. We prefer ports scripts to simply REQUIRE: LOGIN, but if there is a good reason to run this script as is that's fine. There is also no $FreeBSD$ line. The attached script sorts things out in a more standard way. hth, Doug On 02/25/2011 20:58, Xin LI wrote: > delphij 2011-02-26 04:58:37 UTC > > FreeBSD ports repository > > Modified files: > net Makefile > Added files: > net/iet Makefile distinfo pkg-descr pkg-plist > net/iet/files ietd.in > Log: > iSCSI Enterprise Target, based on a original port by QuadStor Systems [1]. > > iSCSI Enterprise Target is a simple open source iSCSI target with > professional features, that works well in enterprise environments > under real workloads, and is scalable and versatile enough to meet > the challenge of future storage needs and developments. > > Part of additional work was sponsored by iXsystems, Inc. > > [1] http://www.quadstor.com/tech-articles/116-iscsi-enterprise-target-iet-on-freebsd.html > > Revision Changes Path > 1.2316 +1 -0 ports/net/Makefile > 1.1 +52 -0 ports/net/iet/Makefile (new) > 1.1 +4 -0 ports/net/iet/distinfo (new) > 1.1 +21 -0 ports/net/iet/files/ietd.in (new) > 1.1 +8 -0 ports/net/iet/pkg-descr (new) > 1.1 +21 -0 ports/net/iet/pkg-plist (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/Makefile.diff?&r1=1.2315&r2=1.2316&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/iet/Makefile > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/iet/distinfo > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/iet/files/ietd.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/iet/pkg-descr > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/iet/pkg-plist > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ --------------040001030900070403020102 Content-Type: text/plain; name="ietd.in" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ietd.in" #!/bin/sh # $FreeBSD$ # # PROVIDE: ietd # REQUIRE: NETWORKING SERVERS DAEMON ldconfig resolv # BEFORE: LOGIN # KEYWORD: shutdown . /etc/rc.subr name="ietd" rcvar=`set_rcvar` command=%%PREFIX%%/sbin/${name} required_modules="iet" stop_precmd="ietd_prestop" load_rc_config $name : ${ietd_enable:="NO"} ietd_prestop() { %%PREFIX%%/sbin/ietadm --op delete } run_rc_command "$1" --------------040001030900070403020102--