Date: Sun, 04 Nov 2012 08:48:54 -0600 From: Joseph a Nagy Jr <jnagyjr1978@gmail.com> To: gahr@FreeBSD.org Cc: ports@freebsd.org, Chris Rees <utisoft@gmail.com> Subject: Re: tk85 Port Maintenance Message-ID: <50968056.8080602@gmail.com> In-Reply-To: <20121102112131.GG90275@gahrfit.gahr.ch> References: <509121B3.3040307@gmail.com> <20121031135749.GC90275@gahrfit.gahr.ch> <50913253.3060700@gmail.com> <20121031152109.GD90275@gahrfit.gahr.ch> <CADLo83_VSLt5t31bJbu3-UCuGkNuNnnBEbMXWVd2fhvVwryP5g@mail.gmail.com> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com> <20121031165507.GF90275@gahrfit.gahr.ch> <509162C9.9060701@gmail.com> <20121102112131.GG90275@gahrfit.gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig41B133323BFAB17B717B0FC3
Content-Type: multipart/mixed;
boundary="------------020101040401070209040406"
This is a multi-part message in MIME format.
--------------020101040401070209040406
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On 11/02/12 06:21, Pietro Cerutti wrote:
> On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote:
>> On 10/31/12 11:55, Pietro Cerutti wrote:
>>> On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
>> <snip>
>>>> New diff[0], undoing some of the earlier changes even though portlin=
t
>>>> complains:
>>>>
>>>> portlint ~/port-maintenance/tk85/
>>>> WARN: Makefile: unless this is a master port, COMMENT has to be set =
by
>>>> "=3D", not by "?=3D".
>>>
>>> This *is* a master port, so it's ok to have COMMENT?=3D
>>>
>>>> WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
>>>
>>> This should be fixed as portlint suggests.
>>>
>>>> WARN: Makefile: no port directory
>>>> /usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
>>>> listed in LIB_DEPENDS.
>>>
>>> I would try and use USE_TCL instead of LIB_DEPENDS here
>>>
>>>> WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 =
in
>>>> Xft.2 unless it is really necessary.
>>>
>>> This should be fixed as portlint suggests.
>>>
>>>> 0 fatal errors and 4 warnings found.
>>>>
>>>> [0]: http://pastebin.com/apf1Y9H0
>>>
>>> I'll have a look at it on Friday, thanks!
>>>
>>>
>>
>> Going ahead to make those changes, old pastebin link is defunct.
>>
>> New diff with all changes:
>> http://pastebin.com/iwhpXfcp
>=20
> This won't apply, either. Could you provide a diff as dumped by svn dif=
f
> in tk85's directory?
>=20
Try this diff:
http://pastebin.com/9YacWnss
portlint complains about two lines using 'tr' instead of '${TR}' in four
different spots but its the only other change that I made - going on
complaints from portlint - that I could think of that are keeping this
from working. If you can think of anything else, let me know.
--=20
Yours in Christ,
Joseph A Nagy Jr
"Whoever loves instruction loves knowledge, But he who hates correction
is stupid." -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
--------------020101040401070209040406--
--------------enig41B133323BFAB17B717B0FC3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQEcBAEBAgAGBQJQloBYAAoJECqR4kIlFcuBoOMH/3Sn2bViMcJY3KvxmDpWWZWQ
TyWXtCCObFFteM34827dykGMpObkVhV+9PgYNH331do+tpc0slpPHhTptDfN+k1K
PTcaAS49RVGTl54QKgl/9h+UewJbrrdmlVcTNQYkM4JIBv/8YZCaSqEX+WV4dGZe
5Ofg2NbBoqw/puAvlEnkUHHpqbR5WfIc5+c4Jpn0v99o1d4KH5Dl6rumjBwvfBLu
Mc6kwBeQDDt3pb3XT5fPMicI5E0DD9LGICiu+dMMNv8L0SYF+g3inst35oBXQQZr
h6Ydf6T+8r6YtLyY31qYc9KUzDSqpLZqkQUQYV5rHccRK+If64klgnksJu4Ji3c=
=AYpW
-----END PGP SIGNATURE-----
--------------enig41B133323BFAB17B717B0FC3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50968056.8080602>