From owner-freebsd-ports@FreeBSD.ORG Sun Nov 4 14:49:00 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 45885E00; Sun, 4 Nov 2012 14:49:00 +0000 (UTC) (envelope-from jnagyjr1978@gmail.com) Received: from mail-gg0-f182.google.com (mail-gg0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id CC7B58FC0A; Sun, 4 Nov 2012 14:48:59 +0000 (UTC) Received: by mail-gg0-f182.google.com with SMTP id l1so915658ggn.13 for ; Sun, 04 Nov 2012 06:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; bh=BmoPQ1gKGmFTnKjtyYntF4X7MWpxyofRgWxRxft5BYY=; b=IJ7TXjHHeQKm6GjOhA71eqeo4yXUaDFMe/y3M5Dg8rHiJKAStkStVBMDW86H3IqRch w4lbGTRE7YLNTD/MYR4HBZUsXiltja2GZce4ynfFOoJAgwT0rAkaDqk40cdZUzLQJhb/ rEISgm7KwhXkE6ihNS9pTCy/hsHkIhIB8a0YBwf/uPy1F0OnK3AfbdL7g3f5YJ2amRyT e+S2wc8YIgvjN9Oiuc2ojbnL3LPd12HOzD48kKO/uF/LhfI5f/KVUdDm53iBPUofKJxa xcV52qrh7sdcdQ/80t5C1ozreV7a3JpuHVubpTpcd5kYWOEFoKbzY2fYUAHOiO5GztBG 8+MA== Received: by 10.236.143.4 with SMTP id k4mr6610482yhj.111.1352040539118; Sun, 04 Nov 2012 06:48:59 -0800 (PST) Received: from alex-laptop.localhost (vid-196.dhcp.grp10.tnmmrl.infoave.net. [204.116.254.196]) by mx.google.com with ESMTPS id a44sm15024862yhe.21.2012.11.04.06.48.57 (version=SSLv3 cipher=OTHER); Sun, 04 Nov 2012 06:48:58 -0800 (PST) Message-ID: <50968056.8080602@gmail.com> Date: Sun, 04 Nov 2012 08:48:54 -0600 From: Joseph a Nagy Jr User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:16.0) Gecko/20121022 Thunderbird/16.0.1 MIME-Version: 1.0 To: gahr@FreeBSD.org Subject: Re: tk85 Port Maintenance References: <509121B3.3040307@gmail.com> <20121031135749.GC90275@gahrfit.gahr.ch> <50913253.3060700@gmail.com> <20121031152109.GD90275@gahrfit.gahr.ch> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com> <20121031165507.GF90275@gahrfit.gahr.ch> <509162C9.9060701@gmail.com> <20121102112131.GG90275@gahrfit.gahr.ch> In-Reply-To: <20121102112131.GG90275@gahrfit.gahr.ch> X-Enigmail-Version: 1.4.5 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig41B133323BFAB17B717B0FC3" X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: ports@freebsd.org, Chris Rees X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Nov 2012 14:49:00 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig41B133323BFAB17B717B0FC3 Content-Type: multipart/mixed; boundary="------------020101040401070209040406" This is a multi-part message in MIME format. --------------020101040401070209040406 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/02/12 06:21, Pietro Cerutti wrote: > On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote: >> On 10/31/12 11:55, Pietro Cerutti wrote: >>> On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote: >> >>>> New diff[0], undoing some of the earlier changes even though portlin= t >>>> complains: >>>> >>>> portlint ~/port-maintenance/tk85/ >>>> WARN: Makefile: unless this is a master port, COMMENT has to be set = by >>>> "=3D", not by "?=3D". >>> >>> This *is* a master port, so it's ok to have COMMENT?=3D >>> >>>> WARN: Makefile: "LIB_DEPENDS" has to appear earlier. >>> >>> This should be fixed as portlint suggests. >>> >>>> WARN: Makefile: no port directory >>>> /usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is >>>> listed in LIB_DEPENDS. >>> >>> I would try and use USE_TCL instead of LIB_DEPENDS here >>> >>>> WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 = in >>>> Xft.2 unless it is really necessary. >>> >>> This should be fixed as portlint suggests. >>> >>>> 0 fatal errors and 4 warnings found. >>>> >>>> [0]: http://pastebin.com/apf1Y9H0 >>> >>> I'll have a look at it on Friday, thanks! >>> >>> >> >> Going ahead to make those changes, old pastebin link is defunct. >> >> New diff with all changes: >> http://pastebin.com/iwhpXfcp >=20 > This won't apply, either. Could you provide a diff as dumped by svn dif= f > in tk85's directory? >=20 Try this diff: http://pastebin.com/9YacWnss portlint complains about two lines using 'tr' instead of '${TR}' in four different spots but its the only other change that I made - going on complaints from portlint - that I could think of that are keeping this from working. If you can think of anything else, let me know. --=20 Yours in Christ, Joseph A Nagy Jr "Whoever loves instruction loves knowledge, But he who hates correction is stupid." -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org --------------020101040401070209040406-- --------------enig41B133323BFAB17B717B0FC3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBAgAGBQJQloBYAAoJECqR4kIlFcuBoOMH/3Sn2bViMcJY3KvxmDpWWZWQ TyWXtCCObFFteM34827dykGMpObkVhV+9PgYNH331do+tpc0slpPHhTptDfN+k1K PTcaAS49RVGTl54QKgl/9h+UewJbrrdmlVcTNQYkM4JIBv/8YZCaSqEX+WV4dGZe 5Ofg2NbBoqw/puAvlEnkUHHpqbR5WfIc5+c4Jpn0v99o1d4KH5Dl6rumjBwvfBLu Mc6kwBeQDDt3pb3XT5fPMicI5E0DD9LGICiu+dMMNv8L0SYF+g3inst35oBXQQZr h6Ydf6T+8r6YtLyY31qYc9KUzDSqpLZqkQUQYV5rHccRK+If64klgnksJu4Ji3c= =AYpW -----END PGP SIGNATURE----- --------------enig41B133323BFAB17B717B0FC3--