From owner-svn-ports-head@FreeBSD.ORG  Sun Feb  9 14:21:12 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2ACA5E00;
 Sun,  9 Feb 2014 14:21:12 +0000 (UTC)
Received: from mx.critical.ch (mx.critical.ch [IPv6:2001:1620:f05::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 903F61957;
 Sun,  9 Feb 2014 14:21:11 +0000 (UTC)
Received: from beaver.home.critical.ch (77-59-132-3.dclient.hispeed.ch
 [77.59.132.3]) (authenticated bits=0)
 by mx.critical.ch (8.14.7/8.14.7/critical-1.0) with ESMTP id s19EL9F4073669;
 Sun, 9 Feb 2014 15:21:09 +0100 (CET)
 (envelope-from ehaupt@FreeBSD.org)
Date: Sun, 9 Feb 2014 15:21:09 +0100
From: Emanuel Haupt <ehaupt@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Subject: Re: svn commit: r343457 - head/audio/p5-Shout
Message-Id: <20140209152109.4290f49678bfd3db76c19340@FreeBSD.org>
In-Reply-To: <EC011389057E119CB2996C3C@atuin.in.mat.cc>
References: <201402091101.s19B1aPh072112@svn.freebsd.org>
 <1E1640591FF296C66F82EF62@atuin.in.mat.cc>
 <20140209131626.ad5097b391ebb1e6d738e28a@FreeBSD.org>
 <D51FCA4F34828A264C471DCA@atuin.in.mat.cc>
 <20140209143756.c1bc46e172d5d5c8979787fc@FreeBSD.org>
 <EC011389057E119CB2996C3C@atuin.in.mat.cc>
X-Mailer: Sylpheed 3.3.0 (GTK+ 2.24.22; amd64-portbld-freebsd10.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Feb 2014 14:21:12 -0000

Mathieu Arnold <mat@FreeBSD.org> wrote:
> +--On 9 f=E9vrier 2014 14:37:56 +0100 Emanuel Haupt <ehaupt@FreeBSD.org>
> wrote:
> |> Yes, and like the wiki[1] says, unless there's a tremendous number
> |> of files and the IO hit is pretty severe you should install them
> |> always.
> |=20
> | So you agree with me that the inclusion is required?
>=20
> Nope, the opposite. The wiki says: "The DOCS/EXAMPLES .if blocks can
> be made unconditional, except in cases when installed files are big
> enough to cause significant I/O overhead."=20
>=20
> In that case, you should have removed the conditional install of the
> files, so that they always get staged, and save make of having to
> parse bsd.port.mk twice :-)

I think you're confused, please look at the Makefile. This is _exactly_
what I made :-)

> |> (Also, if those are examples, they should go in EXAMPLESDIR)
> |=20
> | I was simply looking at the aspect of converting the port to support
> | staging. I don't know if the application requires the files to be
> | installed in EXAMPLESDIR or DOCSDIR.
>=20
> If they're manually installed by the port, that is, not needed, and
> they're called example* you can safely assume that they're examples,
> and thus, need to go into the examples directory :-)

I wouldn't be so sure. Manual installations in post-install sections
are often a result of broken Makefiles. You might be right here but
maybe not. All I'm saying is that I do not know for sure as I don't
know the application (port) good enough to make this decision.

Emanuel