From owner-freebsd-rc@FreeBSD.ORG Wed Nov 30 18:56:30 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 463FC106564A for ; Wed, 30 Nov 2011 18:56:30 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 06BB78FC08 for ; Wed, 30 Nov 2011 18:56:29 +0000 (UTC) Received: by ywp17 with SMTP id 17so1505661ywp.13 for ; Wed, 30 Nov 2011 10:56:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=nvhe8Fi2C5KAI1IllDTvK0WSq9xfW4wyyelKGVjrUMc=; b=XDZi3f7P727eY22hgEDH3Wu7jQkMwxESDnPn/95pX+dg2CwLPE7UYw3Cb3W5+OOZ0F Ygm4Yx0c7CDC204xaU/QcnYs25pcGjnwmId1fWzlkb9vNh4t3z6n+UTG4MWj3lWLM45X HFt5tAl7jkVTamRRoYhHolTpV1gAAlLD1rYsc= Received: by 10.50.169.33 with SMTP id ab1mr4156923igc.0.1322679389475; Wed, 30 Nov 2011 10:56:29 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.12.139 with HTTP; Wed, 30 Nov 2011 10:55:58 -0800 (PST) In-Reply-To: <4ED67B8F.50109@yandex.ru> References: <4ED66DCB.1040102@yandex.ru> <4ED67B8F.50109@yandex.ru> From: Chris Rees Date: Wed, 30 Nov 2011 18:55:58 +0000 X-Google-Sender-Auth: Lee7phmH9wOm3nZnUdn3A0jQdTg Message-ID: To: Ruslan Mahmatkhanov Content-Type: text/plain; charset=KOI8-R Cc: freebsd-rc@freebsd.org Subject: Re: rc-script review request X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2011 18:56:30 -0000 On 30 November 2011 18:53, Ruslan Mahmatkhanov wrote: > Chris Rees wrote on 30.11.2011 22:15: >> On 30 November 2011 17:54, Ruslan Mahmatkhanov wrote: >>> Hello. >>> >>> I'm planning to finish repocopy of www/zope213 this evening. Would you >>> please review rc-script that is supplied with it [1]? >>> >>> I get this one from www/zope211 and minimally changed it, and as far i >>> can tell dougb@ was the last person who touched it, so it should be ok, >>> but i'm asking for review just for the case. >>> >>> I'm attached the script in question and provide the link to it for the >>> case if mailmain will eat it. >>> >>> Thank you much in advance. >> >> I could get yelled at for this, but normally I'd prefer: > > Please yell, i'm not experienced in rc at all, so i'll be glad any > guidance (in any form) to raise it (experience) :). But i thought that > it's safe to use existing scripts from the tree. > >> start_cmd="${name}_start" >> >> over >> >> start_cmd="zope213_start". >> >> Chris > > Fixed, thank you. I also added `KEYWORD: shutdown' per PH, because of > zope starting under non-root user. Is there still any problems in the > script? Updated version here: > > https://github.com/mexicarne/zope/blob/master/www/zope213/files/zope213.in I'm not going to sign you off on it, but it looks OK to me. Doug will be back soon :) Chris