From owner-cvs-src@FreeBSD.ORG Tue Nov 30 20:11:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EE4D16A4CF for ; Tue, 30 Nov 2004 20:11:02 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0222F43D64 for ; Tue, 30 Nov 2004 20:11:02 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 4035 invoked from network); 30 Nov 2004 20:11:01 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 30 Nov 2004 20:10:59 -0000 Received: from qa4379.itdev.weather.com (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iAUKAW0A089425; Tue, 30 Nov 2004 15:10:47 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson Date: Tue, 30 Nov 2004 13:41:00 -0500 User-Agent: KMail/1.6.2 References: <200411301748.iAUHmAiK010161@repoman.freebsd.org> In-Reply-To: <200411301748.iAUHmAiK010161@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411301341.01331.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci_link.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2004 20:11:02 -0000 On Tuesday 30 November 2004 12:48 pm, Nate Lawson wrote: > njl 2004-11-30 17:48:10 UTC > > FreeBSD src repository > > Modified files: > sys/dev/acpica acpi_pci_link.c > Log: > Don't bother locking in attach(). At boot time, we're single-threaded > anyway and for some reason, witness seems confused about what's already > locked and triggers a false panic. Witness doesn't get confused, there's some other bug. I'm not sure that all device attachments are always single-threaded though. Imagine hotplugging a docking station, that's going to add a new PCI bus. It probably won't have an internal programming router (probably not physically possible), but I don't think we should assume for now that attach is only a boot-time scenario. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org