Date: Sun, 19 Aug 2018 12:04:22 -0700 From: Xin Li <delphij@FreeBSD.org> To: Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338059 - in head: . contrib/ntp/lib/isc contrib/ntp/sntp/libevent crypto/heimdal/lib/roken crypto/openssh include lib/libc/gen lib/libc/include sys/crypto/chacha20 Message-ID: <ed4382d3-0ab8-3448-f008-11f3dcc3a7f8@FreeBSD.org> In-Reply-To: <CAPQ4ffuGy%2BCCJhTQv2%2B%2By%2BjL5kRTO8x0=fO7WFJL5bLDzeXBXA@mail.gmail.com> References: <201808191740.w7JHeoSj052259@repo.freebsd.org> <CAPQ4ffuGy%2BCCJhTQv2%2B%2By%2BjL5kRTO8x0=fO7WFJL5bLDzeXBXA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--eeiQhzNJ1EI3a3mnEDtJirIMMYRKnOj1m
Content-Type: multipart/mixed; boundary="F5ncgHEcc1s6LUxBlaulLdj6aIhmBfVjD";
protected-headers="v1"
From: Xin Li <delphij@FreeBSD.org>
To: Oliver Pinter <oliver.pinter@hardenedbsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
svn-src-head@freebsd.org
Message-ID: <ed4382d3-0ab8-3448-f008-11f3dcc3a7f8@FreeBSD.org>
Subject: Re: svn commit: r338059 - in head: . contrib/ntp/lib/isc
contrib/ntp/sntp/libevent crypto/heimdal/lib/roken crypto/openssh include
lib/libc/gen lib/libc/include sys/crypto/chacha20
References: <201808191740.w7JHeoSj052259@repo.freebsd.org>
<CAPQ4ffuGy+CCJhTQv2++y+jL5kRTO8x0=fO7WFJL5bLDzeXBXA@mail.gmail.com>
In-Reply-To: <CAPQ4ffuGy+CCJhTQv2++y+jL5kRTO8x0=fO7WFJL5bLDzeXBXA@mail.gmail.com>
--F5ncgHEcc1s6LUxBlaulLdj6aIhmBfVjD
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 8/19/18 11:27, Oliver Pinter wrote:
>> Modified: head/crypto/heimdal/lib/roken/rand.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/crypto/heimdal/lib/roken/rand.c Sun Aug 19 17:36:50 2018 (r33=
8058)
>> +++ head/crypto/heimdal/lib/roken/rand.c Sun Aug 19 17:40:50 2018 (r33=
8059)
>> @@ -37,7 +37,6 @@ void ROKEN_LIB_FUNCTION
>> rk_random_init(void)
>> {
>> #if defined(HAVE_ARC4RANDOM)
>> - arc4random_stir();
>> #elif defined(HAVE_SRANDOMDEV)
>> srandomdev();
>> #elif defined(HAVE_RANDOM)
>=20
> This hunk of the patch looks weird.
>=20
> Isn't it would better to undef HAVE_ARC4RANDOM without deleting the
> arc4random_stir()?
> Or delete the macro part of detection like
No that would be wrong. The intention is to explicitly say "If
HAVE_ARC4RANDOM, do nothing for rk_random_init()".
undef HAVE_ARC4RANDOM is not an option because that means the code would
no longer use arc4random().
Cheers,
--F5ncgHEcc1s6LUxBlaulLdj6aIhmBfVjD--
--eeiQhzNJ1EI3a3mnEDtJirIMMYRKnOj1m
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCgAGBQJbeb85AAoJEJW2GBstM+nsRcUP/1rTvZSzkN9N0gEpgcUse77l
qgVvkQV9cTnmEBLCPEzLQMbpfkSn9YqWmphmwQNNP8E34EM/ywxrr0bqZF0P4ceU
ZFZC1aURr6WW08YyyoTEfHrYfl5Ku/yA/qN82BNnpuV5mcCMLL7sVTcV4uqZBMUu
U3cKFDPbxjzwU28whnejLh/HkZmDa6Gq7KmyqS3fKvjdBga8dylPcTxmb98UdHwZ
8A5EUpQY/ezEKKBcvsPl/oTxxrVfL2ICOjNvKSvhzOu6kmmVrDjdwxjTKyD8JGoE
3w0Yt26ctwJ58buKVB+mZdmenLPCS4S0InfzfqBzQWeimYTBKXdiyU3dP9rFolx2
GA/Yp7q86khhucBRnvkNtjCj/VCUYzNcPUOpI7v5tk/DJ6jSR06xSG1COBFJPDrF
8N06oRGbFYvTL4xGdrLcKC/4tUlGGLdfT0UdF6ZSMG7tct6iPWO/lca0zw5ZZWZv
GRcB8RDDQ0giEy0Ao+773SnJW0uYn4ZxBN3y5Wzjwf4jjoYOFTl1wjE4WHhpY53J
3eywgfKPSeCsp4uvI0+vgZjptZcSMXNJB0rKci5vs+YPZRscdXq2LW4flRcbZJrh
xsB8/W97Zv7cnEY3sSfyPSGwWaP8DEu7HsV0KVQEt4+2zl40zi4AOUxpAGYCQr+I
F41fWcT2ltnLSG9raqhZ
=uAhd
-----END PGP SIGNATURE-----
--eeiQhzNJ1EI3a3mnEDtJirIMMYRKnOj1m--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ed4382d3-0ab8-3448-f008-11f3dcc3a7f8>