From owner-freebsd-bugs Sun Apr 8 17:10: 8 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id D796637B422 for ; Sun, 8 Apr 2001 17:10:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f390A2u47572; Sun, 8 Apr 2001 17:10:02 -0700 (PDT) (envelope-from gnats) Date: Sun, 8 Apr 2001 17:10:02 -0700 (PDT) Message-Id: <200104090010.f390A2u47572@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Gregory Bond Subject: Re: kern/26317: /modules not created by make installkernel Reply-To: Gregory Bond Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR kern/26317; it has been noted by GNATS. From: Gregory Bond To: David Taylor Cc: freebsd-gnats-submit@FreeBSD.ORG Subject: Re: kern/26317: /modules not created by make installkernel Date: Mon, 09 Apr 2001 10:03:24 +1000 This is a multipart MIME message. --==_Exmh_8133331360 Content-Type: text/plain; charset=us-ascii > It should at least bomb out with an error message, instead of pretending it > succesfully installed your kernel and modules, even though what it > _actually_ did was install one module as '/modules'... A simple patch to achieve this is attached. (I.e. install into /modules/ rather than /modules to force the error to be trapped.) --==_Exmh_8133331360 Content-Type: text/plain ; name="patch"; charset=us-ascii Content-Description: patch Content-Disposition: attachment; filename="patch" Index: kmod.mk =================================================================== RCS file: /usr/ncvs/src/sys/conf/kmod.mk,v retrieving revision 1.82.2.5 diff -u -r1.82.2.5 kmod.mk --- kmod.mk 2001/03/05 06:14:21 1.82.2.5 +++ kmod.mk 2001/04/08 23:59:26 @@ -217,7 +217,7 @@ realinstall: _SUBDIR ${INSTALL} ${COPY} -o ${KMODOWN} -g ${KMODGRP} -m ${KMODMODE} \ - ${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR} + ${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR}/ .if defined(LINKS) && !empty(LINKS) @set ${LINKS}; \ while test $$# -ge 2; do \ --==_Exmh_8133331360-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message