From owner-svn-src-all@freebsd.org Sat Sep 5 02:57:39 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 676793DA0B6 for ; Sat, 5 Sep 2020 02:57:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bjzjt3000z3Tyq for ; Sat, 5 Sep 2020 02:57:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x731.google.com with SMTP id w186so8387773qkd.1 for ; Fri, 04 Sep 2020 19:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JXWQIB4W8LjUZMOYinRoFezwT1NEaEECi4WPAatIPmI=; b=pEcOsXMZ5SauwLEmPpxQMUu+XqHE3G/1GkeuTzcr6wBc18LGl48/GQxYsLLZOFSOor 82BPPO92X9VRDCizm3iAiQiv6NPpLT4rHYwn4t4tWN6oATQMRWqsZ3uDgz20eTQZ0lDa NSnaC9EPiC7A54NWcnhzM41+CvTFKob6dLrLbAGhrqfFLrvMBLfJLZvI9pAw+M0L5yru ebaYEeojQ6rjQWOiwhqnw4iq63SPRrUCkUog9WOY4SKFmIWE2HDVEBMLH9cVN7b85SJz o2LbSkb74J4VvSPfA+v6WcjyAA8c+xVrhZrY8P8YNpmzgFC1YaNkIPT+rb7LUBXaSpL4 xyGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JXWQIB4W8LjUZMOYinRoFezwT1NEaEECi4WPAatIPmI=; b=YdxfP6IkJd6buD0QzUwULaQuZfAwRXJKQYgzHnEkA6N4Rd+SbYi4txKmFuoHTZ6rsY NuKFSTjDcOHxaEDPdadDrV0sYBuX8IaOH+T24ufT0pbJiZqmnPxBEW7n7Wvxqs3CyKyP FuOvsxwhmqIWEi6qFW784flFAk89G2IWdav0PRqyhWrj7HNJtmu+8F5pI8spu7InCAqw lkSJZ6sPrNmBszryc5uerWSGvjtyxZ8v2/szbCyoTx5h9msqSBUsPnU/6OSWO+5Tfei9 sCePhOVkbGIqLfIujz1m1abvBHXwvDCPGpC22iCdbxy/XwkvgIqGzF50uf0Jio9tgVeC 7LkA== X-Gm-Message-State: AOAM533hquwV9+hoEXinW8+hKRfOLYqwT740jmOyZ50+W2Pg2Ku432Yw LJPXcaUQC2G0HBRoOMm4sKJAO8DjNqddcax6sZwSUg== X-Google-Smtp-Source: ABdhPJwFV056P8NbdRJMmE/N45KcMdc5GO5kKL+EzV3CycE5lYeZolqZQsZlLebbtGVPjVSfvJuwXnJL6SsxS4rcG7k= X-Received: by 2002:a37:b801:: with SMTP id i1mr10182913qkf.240.1599274657108; Fri, 04 Sep 2020 19:57:37 -0700 (PDT) MIME-Version: 1.0 References: <202009012119.081LJERb018106@repo.freebsd.org> <95844C00-D10A-456D-AD29-DF572043074F@fh-muenster.de> <20200902020507.GA38274@FreeBSD.org> <20200902180626.GA88595@FreeBSD.org> <6124a908-25a5-e023-16da-7963ba229b7f@FreeBSD.org> <08636D5E-AA07-4AE7-B5AC-656B08CF564B@fh-muenster.de> <20200903024226.GA54078@FreeBSD.org> <60ea593f-8258-e30d-b897-f162168b44d3@cs.duke.edu> <20200905010510.GA26297@lonesome.com> In-Reply-To: <20200905010510.GA26297@lonesome.com> From: Warner Losh Date: Fri, 4 Sep 2020 20:57:25 -0600 Message-ID: Subject: Re: svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph... To: Mark Linimon Cc: Andrew Gallatin , Alexey Dokuchaev , Michael Tuexen , Pedro Giffuni , Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 4Bjzjt3000z3Tyq X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=pEcOsXMZ; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::731) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.98 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.06)[-1.061]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.99)[-0.990]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.93)[-0.933]; RCPT_COUNT_SEVEN(0.00)[9]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::731:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[svn-src-all]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Sep 2020 02:57:39 -0000 On Fri, Sep 4, 2020, 7:05 PM Mark Linimon wrote: > On Fri, Sep 04, 2020 at 02:15:04PM -0400, Andrew Gallatin wrote: > > and I also anticipate it will cause problems with MFCs > > And existing PRs and DRs. > Or we could just not bother we these changes at all. It's a pipe dream we will ever be style(9) compliant in all our code, or that we can magically have a tool to enforce in new commits. We have better things to worry about. We should continue to ignore this non problem and for new users point them at the 95% correct format thing to run their submitted patches if they submit something too far out of whack. The last sweep deleted a boatload of blank lines that were in there on purpose. Not worth adding them back, but still annoying to no real benefit. I just don't see the benefits at all of doing anything here. The few reviews that I've seen mention it seem to be the right level of effort. Warner >