From owner-freebsd-pf@FreeBSD.ORG Wed Feb 25 19:50:07 2009 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0585B106566B for ; Wed, 25 Feb 2009 19:50:07 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186]) by mx1.freebsd.org (Postfix) with ESMTP id 8B37F8FC13 for ; Wed, 25 Feb 2009 19:50:06 +0000 (UTC) (envelope-from max@love2party.net) Received: from vampire.homelinux.org (dslb-088-066-054-118.pools.arcor-ip.net [88.66.54.118]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0MKv1o-1LcPlc3dEU-000E8d; Wed, 25 Feb 2009 20:50:04 +0100 Received: (qmail 65701 invoked from network); 25 Feb 2009 19:50:04 -0000 Received: from fbsd8.laiers.local (192.168.4.200) by mx.laiers.local with SMTP; 25 Feb 2009 19:50:04 -0000 From: Max Laier Organization: FreeBSD To: Artis Caune Date: Wed, 25 Feb 2009 20:50:02 +0100 User-Agent: KMail/1.11.0 (FreeBSD/8.0-CURRENT; KDE/4.2.0; i386; ; ) References: <9e20d71e0902250435y6e090fb0rc138233242fe7d60@mail.gmail.com> <200902251442.43794.max@love2party.net> <9e20d71e0902250610l62a42a99t5b9683aefb08c7cf@mail.gmail.com> In-Reply-To: <9e20d71e0902250610l62a42a99t5b9683aefb08c7cf@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902252050.02682.max@love2party.net> X-Provags-ID: V01U2FsdGVkX1+XcFfz+g+LSklR3rcAPF6AgP8o7YaeOuAI5BE lnpRkby0f/wto8aoATMNU+2EvKGog5Q2E3VBWz68cDZkBSYgGE +UR0kmGRWRKD0joYv2v1g== Cc: samm@os2.kiev.ua, freebsd-pf@freebsd.org Subject: Re: openbsd spamd is leaking memory? X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Technical discussion and general questions about packet filter \(pf\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Feb 2009 19:50:07 -0000 On Wednesday 25 February 2009 15:10:04 Artis Caune wrote: > 2009/2/25 Max Laier : > > Hello Artis, > > > > looks like a valid catch to me. I'm CC'ing the upstream maintainer (Bob, > > that's you, right?) From a quick glance there is also a minor leak in > > readsuffixlists in the goto bad case. Bob Beck has meanwhile committed the slightly more encompassing fix which can be obtained via webcvs: http://www.openbsd.org/cgi- bin/cvsweb/src/libexec/spamd/grey.c.diff?r1=1.45;r2=1.46 Alex, do you have time to roll a new release or would you prefer the patch applied via the ports patch facilities? > I'm running spamd with this patch more than 2h and no leaks :) > > > > --- grey.c.orig 2008-12-07 23:12:52.000000000 +0200 > +++ grey.c 2009-02-25 15:22:48.000000000 +0200 > @@ -512,7 +512,8 @@ > dbc->act = 0; > dbc->dsiz = 0; > SLIST_REMOVE_HEAD(&db_changes, entry); > - > + free(dbc); > + dbc = NULL; > } > return(ret); > } -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News