From owner-freebsd-geom@freebsd.org Thu May 19 19:58:56 2016 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B537B42020 for ; Thu, 19 May 2016 19:58:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7D3171A4C for ; Thu, 19 May 2016 19:58:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 79037B4201E; Thu, 19 May 2016 19:58:56 +0000 (UTC) Delivered-To: geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78A55B4201C for ; Thu, 19 May 2016 19:58:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4E6521A4A for ; Thu, 19 May 2016 19:58:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x229.google.com with SMTP id t40so29307515ioi.0 for ; Thu, 19 May 2016 12:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=ni3XQ2Fv3KiXMKEwYiQC0scsA+fc4g2ZSpxyNEfEYew=; b=is5fWV3f7CF88CMLN7O0TRptLkJJ6TMdjj2OVPiaSSrqVRc9AwFSAWv/etQhIR3bH1 /aTzKk3e6r2sptOMjxnkocY+C7QlIab9aFl7UIaKU0Mm9a3T31j+xVFTI+ZtinRgtT/L QFZQlKhqIpAes3JMbv1ObXPqOwJs5CLouAu5g1xkQY+Z3/de/cz9uZ0apA5p18ylPkvo 8uzl3mTx4wBH/aeYTTvdjlw+BDJvEuxkRJPslEiX3SqLyYMZishd2T7kFRCSYhelHaih 0fQw1ElMFKXfTcFHe9yMRhe8u4V7oLB1sFx1fhj4pZ+fEA2M7a8j7P2FmJkoUG+uBne2 3hxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=ni3XQ2Fv3KiXMKEwYiQC0scsA+fc4g2ZSpxyNEfEYew=; b=cxD5plNGq7shpaanWOqbEfvFwwif0JY5sHpvziBHuSgdW4EtcDe5QWsIm2tcJ4FNgX UbEMrjGo2F3Z8npKQ1OLDdqvTrP+kDaxRIIdjxlOogGmq626uw7xPdpeXWB50T1pec+f 01fdyE6rjtN0J5FjV+wPxR4iA1VnSnRauAFLwkElo6gcnZpFPkW+QPbaFETZ0AHSkCN3 tahTh8pucgmaEWbgnkKVOpWgdaGjEN1prbOE6yXrPJ3qSX/GytJQP3WWCKzzkVGLeaXV dR4svFNPYXsZMYxF1E848Gzby93ddo/H4Qc0YTiTBD1yUeGWuNbxb5ZuvuVOzOM7F3g4 7Zvg== X-Gm-Message-State: AOPr4FXQLt5hLwurGOcwY9/A/uXqBs4xPHJgISZd6Ug91m/GKWj2KHegknjkgql6mxo0VNOsDCwuwn2+7B5hZQ== MIME-Version: 1.0 X-Received: by 10.36.78.67 with SMTP id r64mr4519237ita.72.1463687935609; Thu, 19 May 2016 12:58:55 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.79.75.68 with HTTP; Thu, 19 May 2016 12:58:55 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: <20160519105634.GO89104@kib.kiev.ua> References: <20160519105634.GO89104@kib.kiev.ua> Date: Thu, 19 May 2016 13:58:55 -0600 X-Google-Sender-Auth: 1rl7IH8SaZS3VPQGythPq5cvSsk Message-ID: Subject: Re: Removing Giant asserts from geom From: Warner Losh To: Konstantin Belousov Cc: geom@freebsd.org, "freebsd-arch@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 19:58:56 -0000 On Thu, May 19, 2016 at 4:56 AM, Konstantin Belousov wrote: > I propose to remove asserts > mtx_assert(&Giant, MA_NOTOWNED); > from the geom KPI. I can't see any reason for the assertion in today's kernel. I might split out the lock / unlock of giant around thread creation since that's different. Warner