From owner-dev-commits-src-branches@freebsd.org Thu Apr 8 21:34:35 2021
Return-Path: <owner-dev-commits-src-branches@freebsd.org>
Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7D8485C0B1E;
Thu, 8 Apr 2021 21:34:35 +0000 (UTC) (envelope-from git@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
[IPv6:2610:1c1:1:606c::19:3])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
client-signature RSA-PSS (4096 bits) client-digest SHA256)
(Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 4FGZKP3ydNz4gpB;
Thu, 8 Apr 2021 21:34:32 +0000 (UTC) (envelope-from git@FreeBSD.org)
Received: from gitrepo.freebsd.org (gitrepo.freebsd.org
[IPv6:2610:1c1:1:6068::e6a:5])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(Client did not present a certificate)
by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3D8E61214E;
Thu, 8 Apr 2021 21:34:31 +0000 (UTC) (envelope-from git@FreeBSD.org)
Received: from gitrepo.freebsd.org ([127.0.1.44])
by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 138LYVIk015493;
Thu, 8 Apr 2021 21:34:31 GMT (envelope-from git@gitrepo.freebsd.org)
Received: (from git@localhost)
by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 138LYVg4015492;
Thu, 8 Apr 2021 21:34:31 GMT (envelope-from git)
Date: Thu, 8 Apr 2021 21:34:31 GMT
Message-Id: <202104082134.138LYVg4015492@gitrepo.freebsd.org>
To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,
dev-commits-src-branches@FreeBSD.org
From: Alan Somers <asomers@FreeBSD.org>
Subject: git: e0c4ed73f3a6 - stable/12 - Modernize geom_stats_snapshot_get
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Git-Committer: asomers
X-Git-Repository: src
X-Git-Refname: refs/heads/stable/12
X-Git-Reftype: branch
X-Git-Commit: e0c4ed73f3a6a83f24d9a0bfe89f288ff1b93463
Auto-Submitted: auto-generated
X-BeenThere: dev-commits-src-branches@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commits to the stable branches of the FreeBSD src repository
<dev-commits-src-branches.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-branches>,
<mailto:dev-commits-src-branches-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-branches/>
List-Post: <mailto:dev-commits-src-branches@freebsd.org>
List-Help: <mailto:dev-commits-src-branches-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-branches>,
<mailto:dev-commits-src-branches-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2021 21:34:36 -0000
The branch stable/12 has been updated by asomers:
URL: https://cgit.FreeBSD.org/src/commit/?id=e0c4ed73f3a6a83f24d9a0bfe89f288ff1b93463
commit e0c4ed73f3a6a83f24d9a0bfe89f288ff1b93463
Author: Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2021-03-03 20:06:38 +0000
Commit: Alan Somers <asomers@FreeBSD.org>
CommitDate: 2021-04-08 21:33:22 +0000
Modernize geom_stats_snapshot_get
* A logically useless memset() is used to fault in some memory pages.
Change it to explicit_bzero so the compiler won't eliminate it.
* Eliminate the second memset. It made sense in the days of the Big
Kernel Lock, but not in the days of fine-grained SMP and especially
not in the days of VDSO.
Sponsored by: Axcient
Reviewed by: phk
Differential Revision: https://reviews.freebsd.org/D29047
(cherry picked from commit f05b724ecb310fb91da1947ae6c68647f58f5f12)
---
lib/libgeom/geom_stats.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/libgeom/geom_stats.c b/lib/libgeom/geom_stats.c
index 450ee491ea1c..7c9191e29686 100644
--- a/lib/libgeom/geom_stats.c
+++ b/lib/libgeom/geom_stats.c
@@ -136,9 +136,8 @@ geom_stats_snapshot_get(void)
free(sp);
return (NULL);
}
- memset(sp->ptr, 0, pagesize * npages); /* page in, cache */
+ explicit_bzero(sp->ptr, pagesize * npages); /* page in, cache */
clock_gettime(CLOCK_REALTIME, &sp->time);
- memset(sp->ptr, 0, pagesize * npages); /* page in, cache */
memcpy(sp->ptr, statp, pagesize * npages);
sp->pages = npages;
sp->perpage = spp;