From owner-freebsd-multimedia@FreeBSD.ORG  Mon Jun 10 13:03:38 2013
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 689D210D
 for <freebsd-multimedia@freebsd.org>; Mon, 10 Jun 2013 13:03:38 +0000 (UTC)
 (envelope-from mailnull@mips.inka.de)
Received: from mail-in-05.arcor-online.net (mail-in-05.arcor-online.net
 [151.189.21.45]) by mx1.freebsd.org (Postfix) with ESMTP id 23EEF16B0
 for <freebsd-multimedia@freebsd.org>; Mon, 10 Jun 2013 13:03:37 +0000 (UTC)
Received: from mail-in-16-z2.arcor-online.net (mail-in-16-z2.arcor-online.net
 [151.189.8.33]) by mx.arcor.de (Postfix) with ESMTP id 391BFE413F
 for <freebsd-multimedia@freebsd.org>; Mon, 10 Jun 2013 15:03:31 +0200 (CEST)
Received: from mail-in-04.arcor-online.net (mail-in-04.arcor-online.net
 [151.189.21.44])
 by mail-in-16-z2.arcor-online.net (Postfix) with ESMTP id 3E2BD21203C
 for <freebsd-multimedia@freebsd.org>; Mon, 10 Jun 2013 15:03:31 +0200 (CEST)
X-Greylist: Passed host: 94.218.182.125
X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-04.arcor-online.net 1E996AA035
Received: from lorvorc.mips.inka.de (dslb-094-218-182-125.pools.arcor-ip.net
 [94.218.182.125])
 by mail-in-04.arcor-online.net (Postfix) with ESMTPS id 1E996AA035
 for <freebsd-multimedia@freebsd.org>; Mon, 10 Jun 2013 15:03:31 +0200 (CEST)
Received: from lorvorc.mips.inka.de (localhost [127.0.0.1])
 by lorvorc.mips.inka.de (8.14.7/8.14.7) with ESMTP id r5AD3UlH069449
 for <freebsd-multimedia@freebsd.org>; Mon, 10 Jun 2013 15:03:30 +0200 (CEST)
 (envelope-from mailnull@lorvorc.mips.inka.de)
Received: (from mailnull@localhost)
 by lorvorc.mips.inka.de (8.14.7/8.14.7/Submit) id r5AD3UAg069448
 for freebsd-multimedia@freebsd.org; Mon, 10 Jun 2013 15:03:30 +0200 (CEST)
 (envelope-from mailnull)
From: naddy@mips.inka.de (Christian Weisgerber)
Subject: Re: multimedia/vlc, audio/flac: utterly broken since FLAC update
Date: Mon, 10 Jun 2013 13:03:30 +0000 (UTC)
Message-ID: <kp4ir2$23hu$1@lorvorc.mips.inka.de>
References: <E1UlvIL-000GMR-HL@apollo.emma.line.org>
Originator: naddy@mips.inka.de (Christian Weisgerber)
To: freebsd-multimedia@freebsd.org
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Jun 2013 13:03:38 -0000

Matthias Andree <mandree@FreeBSD.org> wrote:

> Fix that with CPPFLAGS+=${LOCALBASE}/include/FLAC

This is generally a bad idea...

> and see that there are other failures, some from a missing #include
> <assert.h>, and other issues.

... because it causes collisions between <FLAC/assert.h> and <assert.h>.

The better fix is to use the FLAC/ prefix for the include headers,
which has always been the correct way.

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de