From owner-freebsd-scsi@freebsd.org  Fri Nov  6 07:59:14 2015
Return-Path: <owner-freebsd-scsi@freebsd.org>
Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id ABED9A26653
 for <freebsd-scsi@mailman.ysv.freebsd.org>;
 Fri,  6 Nov 2015 07:59:14 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9721014A1
 for <freebsd-scsi@FreeBSD.org>; Fri,  6 Nov 2015 07:59:14 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tA67xElZ017293
 for <freebsd-scsi@FreeBSD.org>; Fri, 6 Nov 2015 07:59:14 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-scsi@FreeBSD.org
Subject: [Bug 204298] xpt_release_device() panic: mutex CAM queue lock not
 owned
Date: Fri, 06 Nov 2015 07:59:14 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: smferris@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-scsi@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-204298-5312-LObF5tAJYo@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-204298-5312@https.bugs.freebsd.org/bugzilla/>
References: <bug-204298-5312@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-scsi>,
 <mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi/>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
 <mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Nov 2015 07:59:14 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204298

--- Comment #6 from Scott M. Ferris <smferris@gmail.com> ---
Created attachment 162840
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=162840&action=edit
revised patch with a LOR fix and mav's cleanups

I attached a revised patch that tries to fix the LOR and incorporate mav's
cleanups.

The acquire side is handled by taking a device ref for the callout before we
know if we need another ref, and releasing the extra ref if we discover we
don't need it.

The release side is handled using CALLOUT_RETURNUNLOCKED so that the callout
can just unlock devq->send_mtx and then xpt_release_device().

-- 
You are receiving this mail because:
You are the assignee for the bug.