Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Oct 2019 07:34:45 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 241237] [NEW PORT] multimedia/kodi-addon-peripheral-joystick-devel: Joystick support for Kodi
Message-ID:  <bug-241237-7788-pTujnHKt4X@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-241237-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-241237-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241237

Tobias Kortkamp <tobik@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch
           Assignee|ports-bugs@FreeBSD.org      |tobik@freebsd.org

--- Comment #4 from Tobias Kortkamp <tobik@freebsd.org> ---
Please address the problems below.

+PORTNAME=3D      kodi-addon-peripheral-joystick
+PORTVERSION=3D   1.4.8
+DISTVERSIONPREFIX=3Dv
+CATEGORIES=3D    multimedia
+PKGNAMESUFFIX=3D -devel

It would be nice if you could set PORTNAME, PKGNAME{PREFIX,SUFFIX}
like I did in multimedia/kodi-addon-inputstream.adaptive-devel and
rename the port dir to multimedia/kodi-addon-peripheral.joystick-devel.
You can also drop GH_PROJECT afterwards.  Please copy BUILD_DEPENDS
and RUN_DEPENDS from there too.

+GH_TAGNAME=3D    7611722a4921b66674a41c3f5322ff0a54246b71

Drop this and DISTVERSIONPREFIX.  The repository has a 1.4.8-Leia
tag with that commit already, so:

DISTVERSION=3D    1.4.8
DISTVERSIONSUFFIX=3D      -Leia

+       @${CP} -f ${FILESDIR}/input.h ${WRKSRC}/src/linux/
+       @${CP} -f ${FILESDIR}/input-event-codes.h ${WRKSRC}/src/linux/

I do not like this at all.  Can this port not use evdev-proto instead
of having its own copy of these headers?

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-241237-7788-pTujnHKt4X>