From owner-cvs-all Mon Feb 11 13:37:48 2002 Delivered-To: cvs-all@freebsd.org Received: from netau1.alcanet.com.au (ntp.alcanet.com.au [203.62.196.27]) by hub.freebsd.org (Postfix) with ESMTP id E6ECB37B41D; Mon, 11 Feb 2002 13:37:26 -0800 (PST) Received: from mfg1.cim.alcatel.com.au (mfg1.cim.alcatel.com.au [139.188.23.1]) by netau1.alcanet.com.au (8.9.3 (PHNE_22672)/8.9.3) with ESMTP id IAA10257; Tue, 12 Feb 2002 08:37:22 +1100 (EDT) Received: from gsmx07.alcatel.com.au by cim.alcatel.com.au (PMDF V5.2-32 #37645) with ESMTP id <01KE6I8PHS1C7QFQW1@cim.alcatel.com.au>; Tue, 12 Feb 2002 08:37:35 +1100 Received: (from jeremyp@localhost) by gsmx07.alcatel.com.au (8.11.6/8.11.6) id g1BLbHe68731; Tue, 12 Feb 2002 08:37:17 +1100 Content-return: prohibited Date: Tue, 12 Feb 2002 08:37:17 +1100 From: Peter Jeremy Subject: Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.c In-reply-to: <20020205164329.A88662@hub.freebsd.org>; from msmith@hub.freebsd.org on Tue, Feb 05, 2002 at 04:43:29PM -0800 To: Mike Smith Cc: Mark Murray , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Reply-To: freebsd-arch@FreeBSD.ORG Mail-Followup-To: Mike Smith , Mark Murray , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-id: <20020212083717.A68671@gsmx07.alcatel.com.au> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline User-Agent: Mutt/1.2.5i References: <20020205164329.A88662@hub.freebsd.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG There was a thread about this on -arch 3 weeks ago. I suggest that -arch is a more appropraite forum for this discussion and have re-directed followups. On 2002-Feb-05 16:43:29 -0800, Mike Smith wrote: >> > I agree with Andrey here, pam_unix(8) should not clobber random()'s >> > internal state. >> >> OK. I have a local patch. As soon as I se that it survives the usual >> build, I'll commit it. > >This won't make random() thread-safe. Please fix the problem properly. 8) Does this mean that we should implement random_r() and friends? Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message