From owner-svn-src-head@freebsd.org Tue Dec 12 19:13:43 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 97A82E80B17; Tue, 12 Dec 2017 19:13:43 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-qt0-x234.google.com (mail-qt0-x234.google.com [IPv6:2607:f8b0:400d:c0d::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6CB7E6CE5F; Tue, 12 Dec 2017 19:13:42 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-qt0-x234.google.com with SMTP id g10so49964647qtj.12; Tue, 12 Dec 2017 11:13:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=k+xzv/q83955CNrZmAo1aDJjBZqBHpVl1CG9x2qtGS4=; b=UD3yrzclvma5vMXiELx6BcjIxy9NTbAXDVx4toMCA3wq7vqWAZ2H+vd3i/Uxbd2xfT Xd5urGOellyJ5lyM5zarNIpLuoymchus3uyAWok8bPxwxys/ba2BfQXzj3f5JsiEGJ2k O/7VBl1K8rq4AjvfpFPh2PjeBnE/Bwf0XuLs1328cwJBJ+hGkNYuhMEIHL9vOEboaD7G 5FQ+UtCkey5X6972lwUwSR1Jlp/Tgp5DA624VpKoJa7VYi0/xgdMUM1vBwg7PWdu70MP OqtqiPviUcaF7W/qkeKAIm+5UgukBaMVBTlkzG91QIYaW+UmBXWxGo38YwNWkIACwW7X P5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=k+xzv/q83955CNrZmAo1aDJjBZqBHpVl1CG9x2qtGS4=; b=VJ8tLhwEEDs5M4UTwuuchHQeaGbyI/T4avvLQEab+hAhB/XfdC9nF64i45N7Aujw15 kTuVUl3r0tn6Ck4E34w90OBvWur8sJ2FbZTPCStaj/oJMIknVX7eITB2YfmlbZdK0NIH GbE554AAMvMDWbFRViKVQ/tSy1ZnjUrK5SWZJejlCLci1WfEssuRvEeE7RVKMD0WNmL+ UXyotXjEo/EMi3z82RRmsqBNPDf30c/deeODVem2hDuMNL0uKHeoiBn0iGyM1Z5LOFQb 3V/ztzwLC4o2+3+08NCxDnGVMN5mOEswUB3omizRXdqvxdToMDdPB6DoFG0WC0eoUNkP G9Yg== X-Gm-Message-State: AKGB3mJpEdoRprAP25gpplTUc3u8JtWBwkI951E2t0IYliqJdUmr7yEr C7vIsirjdBOHxOsrbfn4lNJq3f5anwUmGO/n4H0= X-Google-Smtp-Source: ACJfBosFhDTJmoU+i6JBOBsl0kA42HlzTumDE2NqR1/YVXH1tR4OtTi2h5RO+6pEx5Chbs2Zz9pgS953b0o4+RR8mPk= X-Received: by 10.200.48.82 with SMTP id g18mr6716183qte.329.1513106020761; Tue, 12 Dec 2017 11:13:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.44.214 with HTTP; Tue, 12 Dec 2017 11:13:39 -0800 (PST) In-Reply-To: References: <201712120946.vBC9krNL075725@repo.freebsd.org> From: Mateusz Guzik Date: Tue, 12 Dec 2017 20:13:39 +0100 Message-ID: Subject: Re: svn commit: r326792 - head/stand/uboot/common To: Warner Losh Cc: Antoine Brodin , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , src-committers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 19:13:43 -0000 How about you both close one PR as a punishment and we pretend this did not happen. The thing to do was to reply to the offending commit or contact the committer on irc. Only in case of no timely response fixing on your own is the right thing to do. On Tue, Dec 12, 2017 at 8:03 PM, Warner Losh wrote: > The email I wrote here also sucks. It was unduly harsh. While the commit > message should have been better, I was too harsh in trying to express this > and giving a better example. > > Warner > > On Tue, Dec 12, 2017 at 5:49 AM, Warner Losh wrote: > > > This commit message sucks. Please use a more descriptive one in the > future > > like "catch up to change rXXXXX that remove the argument from interact." > If > > you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. > > Your message is utterly useless. It doesn't even say what arch is broken. > > > > Warner > > > > Warner > > > > On Dec 12, 2017 1:47 AM, "Antoine Brodin" wrote: > > > >> Author: antoine > >> Date: Tue Dec 12 09:46:53 2017 > >> New Revision: 326792 > >> URL: https://svnweb.freebsd.org/changeset/base/326792 > >> > >> Log: > >> Attempt to unbreak buildworld > >> > >> Modified: > >> head/stand/uboot/common/main.c > >> > >> Modified: head/stand/uboot/common/main.c > >> ============================================================ > >> ================== > >> --- head/stand/uboot/common/main.c Tue Dec 12 06:56:21 2017 > >> (r326791) > >> +++ head/stand/uboot/common/main.c Tue Dec 12 09:46:53 2017 > >> (r326792) > >> @@ -500,7 +500,7 @@ main(int argc, char **argv) > >> archsw.arch_readin = uboot_readin; > >> archsw.arch_autoload = uboot_autoload; > >> > >> - interact(NULL); /* doesn't return */ > >> + interact(); /* doesn't return */ > >> > >> return (0); > >> } > >> > >> > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > -- Mateusz Guzik