Date: Mon, 23 Jan 2012 16:39:29 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: edwin@FreeBSD.org Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/164405: [PATCH] sysutils/tmux - install bash completions into completion dir Message-ID: <20120123153929.GC48121@gahrfit.gahr.ch> In-Reply-To: <201201231510.q0NFAImq009033@freefall.freebsd.org> References: <201201231510.q0NFAImq009033@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ZmUaFz6apKcXQszQ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
I wouldn't bother too much to make an OPTION and depend on bash. Let us
just hardlink the file and be done with it, as deskutils/calibre,
deskutils/griffith, and possibly others do as well. What about this
patch?
Index: Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/pcvs/ports/sysutils/tmux/Makefile,v
retrieving revision 1.32
diff -u -r1.32 Makefile
--- Makefile 23 Sep 2011 22:25:37 -0000 1.32
+++ Makefile 23 Jan 2012 15:36:23 -0000
@@ -19,7 +19,9 @@
=20
MAN1=3D tmux.1
=20
-PLIST_FILES=3D bin/tmux
+PLIST_FILES=3D bin/tmux \
+ etc/bash_completion.d/tmux
+PLIST_DIRTRY=3D etc/bash_completion.d
=20
PORTDOCS=3D CHANGES FAQ NOTES
PORTEXAMPLES=3D *
@@ -63,6 +65,8 @@
@${INSTALL_MAN} ${WRKSRC}/tmux.1 ${MANPREFIX}/man/man1
=20
post-install:
+ ${MKDIR} ${PREFIX}/etc/bash_completion.d
+ @${LN} ${WRKSRC}/examples/bash_completion_tmux.sh ${PREFIX}/etc/bash_comp=
letion.d/tmux
.if !defined(NOPORTDOCS)
@${MKDIR} ${DOCSDIR}
.for i in ${PORTDOCS}
On 2012-Jan-23, 15:10, edwin@FreeBSD.org wrote:
> Synopsis: [PATCH] sysutils/tmux - install bash completions into completio=
n dir
>=20
> Responsible-Changed-From-To: freebsd-ports-bugs->gahr
> Responsible-Changed-By: edwin
> Responsible-Changed-When: Mon Jan 23 15:10:18 UTC 2012
> Responsible-Changed-Why:=20
> Over to maintainer (via the GNATS Auto Assign Tool)
>=20
> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D164405
--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org
PGP Public Key:
http://gahr.ch/pgp
--ZmUaFz6apKcXQszQ
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iEYEARECAAYFAk8dfzEACgkQwMJqmJVx947JaACgoVq8/tUuBV1hUsw9AcdaDnCc
rxcAoLUdSh+l+q6A5ZKSazEdjtBZsncy
=kqxs
-----END PGP SIGNATURE-----
--ZmUaFz6apKcXQszQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120123153929.GC48121>