From owner-cvs-all@FreeBSD.ORG  Mon Dec 17 05:34:16 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6897E16A469;
	Mon, 17 Dec 2007 05:34:16 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 44CAB13C469;
	Mon, 17 Dec 2007 05:34:16 +0000 (UTC) (envelope-from sam@errno.com)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id lBH5YFF7095082
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sun, 16 Dec 2007 21:34:15 -0800 (PST) (envelope-from sam@errno.com)
Message-ID: <47660A57.8060108@errno.com>
Date: Sun, 16 Dec 2007 21:34:15 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071125)
MIME-Version: 1.0
To: Kip Macy <kmacy@FreeBSD.org>
References: <200712170419.lBH4JPJg026761@repoman.freebsd.org>
In-Reply-To: <200712170419.lBH4JPJg026761@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC-Rhyolite-Metrics: o.com; whitelist
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet if_ether.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Dec 2007 05:34:16 -0000

Kip Macy wrote:
> kmacy       2007-12-17 04:19:25 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/netinet          if_ether.c 
>   Log:
>   Don't panic in arpresolve if we're given a null mbuf. We could
>   insist that the caller just pass in an initialized mbuf even
>   if didn't have any data - but that seems rather contrived.
>   

You don't explain the purpose of this change.  arpresolve has been 
designed for use in the xmit path where there is always an mbuf.  This 
feels like you are now applying it for a different purpose and it might 
be better to define a different api than overload arpresolve's intended 
purpose.

    Sam