Date: Fri, 30 Jul 1999 00:19:14 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: "Robert V. Baron" <rvb@cs.cmu.edu> Cc: Julian Elischer <julian@whistle.com>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/coda cnode.h coda_io.h coda_namecache.c coda_namecache.h coda_pioctl.h coda_psdev.c coda_subr.c coda_vfsops.c coda_vnops.c coda_vnops.h Message-ID: <1045.933286754@critter.freebsd.dk> In-Reply-To: Your message of "29 Jul 1999 13:53:35 EDT." <yzszp0fe40w.fsf@sicily.odyssey.cs.cmu.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <yzszp0fe40w.fsf@sicily.odyssey.cs.cmu.edu>, "Robert V. Baron" writes: >Also, given there is a hefty boilerplate of copyrights and stuff at >the head of the file, you don't immediately see code w or w/o the $Log. >So why take it out? The copyright is static and doesn't foul up diffs or goes rococco on people who import the files in their own CVS trees &c &c. $Log$ is one of those ideas which work great in limited scope, but once you have more than one CVS tree involved things get more and more nasty. Poul-Henning PS: you you look at this line in -current: coda_venus.c: *dev = udev2dev(outp->dev, 2); The "2" should be 1 if the outp->dev is a block dev and 0 if it is a char dev. I could not figure it out by examining the code so the 2 will drop you into the debugger/panic if it is ever hit... -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1045.933286754>