From owner-cvs-src@FreeBSD.ORG Sun Jun 8 00:26:38 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 86FD937B401; Sun, 8 Jun 2003 00:26:38 -0700 (PDT) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB1A243FB1; Sun, 8 Jun 2003 00:26:36 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 527AA51A78; Sun, 8 Jun 2003 16:56:33 +0930 (CST) Date: Sun, 8 Jun 2003 16:56:33 +0930 From: Greg 'groggy' Lehey To: Juli Mallett Message-ID: <20030608072633.GD9304@wantadilla.lemis.com> References: <200306080618.h586ID4a026484@repoman.freebsd.org> <20030608021354.A40746@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xB0nW4MQa6jZONgY" Content-Disposition: inline In-Reply-To: <20030608021354.A40746@FreeBSD.org> User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/asf Makefile asf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jun 2003 07:26:39 -0000 --xB0nW4MQa6jZONgY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sunday, 8 June 2003 at 2:13:54 -0500, Juli Mallett wrote: > * Greg Lehey [ Date: 2003-06-08 ] > [ w.r.t. cvs commit: src/usr.sbin/asf Makefile asf.c ] >> grog 2003/06/07 23:18:13 PDT >> >> FreeBSD src repository >> >> Added files: >> usr.sbin/asf Makefile asf.c >> Log: >> Introducing asf, a helper program for kernel debugging. > > This looks pretty messy and doesn't even have a license on it. Yup. To be added. > Will it be tied to the build? That was my intention. Lots of other debugging tools are tied to the build. > Any reason it doesn't use the getopt(3) function, or in any way look > like the normal BSD style for utilities? It has a different origin. > Please use a paths.h instead of the evilly hardcoded program paths. paths.h is a bit of overkill for one file. But agreed, pathname definitions would be tidier. Feel free to fix. > If this won't be tied up to the build it should probably be in > src/tools, and I'd argue it should be there anyway. I thought about this. In fact, it started off that way, but the way this is intended to be used would make it inconvenient. Greg -- See complete headers for address and phone numbers --xB0nW4MQa6jZONgY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE+4uUpIubykFB6QiMRAnGWAJoDLYtqDMlbSIko2J7cyrcDAZKZIwCfW/zK diGme9wTYWkd+fPTq8+nst0= =sA4M -----END PGP SIGNATURE----- --xB0nW4MQa6jZONgY--