From owner-svn-src-all@freebsd.org Sun Jul 5 20:49:10 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 687FFAD96; Sun, 5 Jul 2015 20:49:10 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 35B981FDD; Sun, 5 Jul 2015 20:49:10 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pactm7 with SMTP id tm7so83988474pac.2; Sun, 05 Jul 2015 13:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=C+sgxsYkc1SkcyUvetD6zv0Fa8G7siO9R3/FB/sasWQ=; b=jboaHvdVg+OIJtzkno85OMUiQWw035pQyhgB4k/S+tOJJq9IxvP/3yshi0ON58dtLe rToJQ0JvA3ReYX3CafdCSL/TMPMobdWdT5K0ZuVYgbuZmZ3cW+MUOXzhz0XPJp3u3pJZ yqDfKL+ZGXA6Pwb9Nv1upbLt3mx6VOgMj6jsoaQxBvUU+33GieRG+LJO1TH7fI1mOZNQ bxLWk2+1YiW/sg0mUYU9zBLgdNdBzugRRQw4VUlY0TL5nvmvdBhpgnxonF4HUUkTsjdm VxVq6eM/3rE9YxHKLwQMbyCUImP7CrKv5woYXb97yVr6hpqA+/pXPVMJ33S+5203wy8H zZUw== X-Received: by 10.66.121.163 with SMTP id ll3mr100481967pab.100.1436129349610; Sun, 05 Jul 2015 13:49:09 -0700 (PDT) Received: from [192.168.20.5] (c-98-247-240-204.hsd1.wa.comcast.net. [98.247.240.204]) by mx.google.com with ESMTPSA id bi4sm15746271pbc.56.2015.07.05.13.49.08 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 05 Jul 2015 13:49:08 -0700 (PDT) Subject: Re: svn commit: r285160 - head/sys/conf Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_745AE214-2FB7-460D-8CC5-38B1AEFD9AD6"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5 From: Garrett Cooper In-Reply-To: <1436126730.1191.4.camel@freebsd.org> Date: Sun, 5 Jul 2015 13:49:06 -0700 Cc: John-Mark Gurney , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <495E11C2-BB42-4687-8551-604C1F14D37E@gmail.com> References: <201507051415.t65EFxWd044357@repo.freebsd.org> <20150705194954.GA8523@funkthat.com> <1436126730.1191.4.camel@freebsd.org> To: Ian Lepore X-Mailer: Apple Mail (2.1878.6) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jul 2015 20:49:10 -0000 --Apple-Mail=_745AE214-2FB7-460D-8CC5-38B1AEFD9AD6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jul 5, 2015, at 13:05, Ian Lepore wrote: > On Sun, 2015-07-05 at 12:49 -0700, John-Mark Gurney wrote: >> Ian Lepore wrote this message on Sun, Jul 05, 2015 at 14:15 +0000: >>> Author: ian >>> Date: Sun Jul 5 14:15:58 2015 >>> New Revision: 285160 >>> URL: https://svnweb.freebsd.org/changeset/base/285160 >>>=20 >>> Log: >>> Ensure all the required files get built when you include the IPSEC = option. >>=20 >> Umm.. This looks more like that IPSEC should require that the crypto >> device be specified instead of fixing it this way... >=20 > I considered that, but rejected it given the presence of crypto | = ipsec > on some of the files already, but not a sufficiency of them to = actually > build sucessfully. Heavily my thinking that was a personal belief = that > if you say "option foo" it should just work without you needing to = know > other (likely not well documented) prerequisite options also need to = be > set. Or=85 just create a manpage that says =93options IPSEC=94 requires = =93device crypto=94? --Apple-Mail=_745AE214-2FB7-460D-8CC5-38B1AEFD9AD6 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVmZhCAAoJEMZr5QU6S73eSZoH/R+MKFsLH8slqXxWmzU72vfJ wxJ+oEI72TSbg7Dv8dY4G2kded4zImmnikqVqUcdrheG2Y2mxmYq77z4MhMY2Yky v6TIegkca2NekA3n+r4FxCOC4uXN3enEvWDxCt3co5QrbQmy61bYw8ELQtTj6HpY bGiV1T5hZL69gzKILrCJ8Vi8QbvSDBa5mysxMJ4vYITNKliG7n72dxko7DmIZGvY VM+M/AjmWpzsGuZVg3wF+F0LBZwijraM66k4sFuGtj72szkaPa+ewFAxmUidBi8t WBY5tJu+Yp2iyREP6TxmSuUT+nC3+erQmEeIXlRh05iEQL1C3fAop06EQP3wovI= =iagf -----END PGP SIGNATURE----- --Apple-Mail=_745AE214-2FB7-460D-8CC5-38B1AEFD9AD6--