From owner-freebsd-current Sat Nov 18 9:28: 8 2000 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (flutter.freebsd.dk [212.242.40.147]) by hub.freebsd.org (Postfix) with ESMTP id D13AC37B4CF for ; Sat, 18 Nov 2000 09:28:05 -0800 (PST) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.1/8.11.1) with ESMTP id eAIKBO733164; Sat, 18 Nov 2000 21:11:25 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: David Malone Cc: current@freebsd.org Subject: Re: Typo in labpc.c In-Reply-To: Your message of "Sat, 18 Nov 2000 17:23:16 GMT." <200011181723.aa82033@salmon.maths.tcd.ie> Date: Sat, 18 Nov 2000 21:11:24 +0100 Message-ID: <33162.974578284@critter> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <200011181723.aa82033@salmon.maths.tcd.ie>, David Malone writes: >I noticed the following while looking through the M_ZERO patches. >When you were cleaning up some dev stuff you made the following >change to labpc.c (revision 1.33): > > > labpcs = malloc(NLABPC * sizeof(struct ctlr *), M_DEVBUF, M_NOWAIT); > if (labpcs) > { > bzero(labpcs, NLABPC * sizeof(struct ctlr *)); > return 1; > } >+ cdevsw_add(&labpc_cdevsw); > return 0; > } > >This seems to only do the cdevsw_add if the malloc failed. I presume >this is the opposit of the intended sense. I'll fix it up if you also >think it looks wrong. If nobody have noticed in "17 months, 2 weeks ago" (as cvs-web says) that labpc doesn't work, the labpc driver should be killed, not fixed. Objections ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message