From owner-svn-ports-head@freebsd.org Thu Nov 7 20:25:03 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B106E1BFC36; Thu, 7 Nov 2019 20:25:03 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.issp.ac.ru", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 478FJG6y6Rz4H9j; Thu, 7 Nov 2019 20:25:02 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from host-213-183-253-153.rev.as20985.net [213.183.253.153:63568] (HELO/EHLO mercury.ph.man.ac.uk, authenticated with PLAIN) by mail.issp.ac.ru with ESMTPSA/inet id xA7KOwXa084828 (using TLSv1.2, with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits), verified NO) Thu, 7 Nov 2019 23:24:58 +0300 (MSK) X-Authentication-Warning: mail.issp.ac.ru: Host host-213-183-253-153.rev.as20985.net [213.183.253.153] claimed to be mercury.ph.man.ac.uk From: Max Brazhnikov To: Mateusz Piotrowski <0mp@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r516987 - in head: net/remotebox net/remotebox/files x11/gcb x11/gcb/files Date: Thu, 07 Nov 2019 23:24:57 +0300 Message-ID: <5176694.8gLySxXtyI@mercury.ph.man.ac.uk> In-Reply-To: <201911071707.xA7H7Pj0023431@repo.freebsd.org> References: <201911071707.xA7H7Pj0023431@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 478FJG6y6Rz4H9j X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.73 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.73)[-0.729,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; ASN(0.00)[asn:42317, ipnet:77.236.32.0/20, country:RU] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Nov 2019 20:25:03 -0000 On Thu, 7 Nov 2019 17:07:25 +0000 (UTC) Mateusz Piotrowski wrote: > Author: 0mp > Date: Thu Nov 7 17:07:24 2019 > New Revision: 516987 > URL: https://svnweb.freebsd.org/changeset/ports/516987 > > Log: > Remove suffix from Icon key in desktop entries > > Suffixes, like .png, are not part of the specification. Although many > ports like misc/xfce4-appfinder have implemented workarounds for it, > ports like x11/rofi are missing icons due to a suffix being present in the > Icon key. > > References: > - https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html > - https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#icon_lookup > > Approved by: portmgr (blanket, runtime fixes) > > Modified: > head/net/remotebox/Makefile > head/net/remotebox/files/remotebox.desktop > head/x11/gcb/Makefile > head/x11/gcb/files/gcb.desktop > > Modified: head/net/remotebox/Makefile > ============================================================================== > --- head/net/remotebox/Makefile Thu Nov 7 17:00:49 2019 (r516986) > +++ head/net/remotebox/Makefile Thu Nov 7 17:07:24 2019 (r516987) > @@ -3,7 +3,7 @@ > > PORTNAME= remotebox > DISTVERSION= 2.5 > -PORTREVISION= 1 > +PORTREVISION= 2 > CATEGORIES= net > MASTER_SITES= http://remotebox.knobgoblin.org.uk/downloads/ > DISTNAME= RemoteBox-${DISTVERSION} > > Modified: head/net/remotebox/files/remotebox.desktop > ============================================================================== > --- head/net/remotebox/files/remotebox.desktop Thu Nov 7 17:00:49 2019 (r516986) > +++ head/net/remotebox/files/remotebox.desktop Thu Nov 7 17:07:24 2019 (r516987) > @@ -5,6 +5,6 @@ Type=Application > Name=Remotebox > GenericName=Remotebox > Comment=Open Source VirtualBox Client with Remote Management > -Icon=remotebox.png > +Icon=remotebox > Exec=remotebox > Categories=System > > Modified: head/x11/gcb/Makefile > ============================================================================== > --- head/x11/gcb/Makefile Thu Nov 7 17:00:49 2019 (r516986) > +++ head/x11/gcb/Makefile Thu Nov 7 17:07:24 2019 (r516987) > @@ -3,7 +3,7 @@ > > PORTNAME= gcb > PORTVERSION= 0.2.8 > -PORTREVISION= 8 > +PORTREVISION= 9 > CATEGORIES= x11 > MASTER_SITES= http://freebsd.flatrate.ru/distfiles/ \ > http://ccbsd9.csie.nctu.edu.tw/~cp76/gcb/ > > Modified: head/x11/gcb/files/gcb.desktop > ============================================================================== > --- head/x11/gcb/files/gcb.desktop Thu Nov 7 17:00:49 2019 (r516986) > +++ head/x11/gcb/files/gcb.desktop Thu Nov 7 17:07:24 2019 (r516987) > @@ -2,7 +2,7 @@ > Encoding=UTF-8 > Name=Gtk Copy-paste Buffer > Comment=A GTK+ tool for managing x11 cut-buffers > -Icon=gcb.png > +Icon=gcb > Exec=gcb -B > Type=Application > Categories=GNOME;Application;System These files look simple. I think they can be removed and replaced with DESKTOP_ENTRIES.