From owner-freebsd-net@FreeBSD.ORG Thu May 8 07:33:50 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D0DA1065672 for ; Thu, 8 May 2008 07:33:50 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outC.internet-mail-service.net (outc.internet-mail-service.net [216.240.47.226]) by mx1.freebsd.org (Postfix) with ESMTP id E48218FC0A for ; Thu, 8 May 2008 07:33:49 +0000 (UTC) (envelope-from julian@elischer.org) Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160) by out.internet-mail-service.net (qpsmtpd/0.40) with ESMTP; Thu, 08 May 2008 11:16:34 -0700 Received: from julian-mac.elischer.org (localhost [127.0.0.1]) by idiom.com (Postfix) with ESMTP id 3AC3C2D600D; Thu, 8 May 2008 00:33:49 -0700 (PDT) Message-ID: <4822ACDB.6040209@elischer.org> Date: Thu, 08 May 2008 00:33:47 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) MIME-Version: 1.0 To: "Bjoern A. Zeeb" References: <4816D1D2.7010603@elischer.org> <20080506202940.K47338@maildrop.int.zabbadoz.net> <4820C8CE.8010309@elischer.org> <20080507074647.B47338@maildrop.int.zabbadoz.net> In-Reply-To: <20080507074647.B47338@maildrop.int.zabbadoz.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD Net Subject: Re: multiple routing tables review patch ready for simple testing. X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2008 07:33:50 -0000 Bjoern A. Zeeb wrote: > On Tue, 6 May 2008, Julian Elischer wrote: > > Hi, > >> Bjoern A. Zeeb wrote: >>> On Tue, 29 Apr 2008, Julian Elischer wrote: >>> >>> Hi, >>> >>>> The patch can be found at >>>> http://www.freebsd.org/~julian/mrt.diff >>>> (or http://www.freebsd.org/~julian/mrt6.diff for RELENG_6) >>>> >>>> or source can be taken from perforce at: >>>> //depot/user/julian/routing/src >>> >>> So after looking at the patch a bit more again, could you add wrapper >>> functions for those like you have done for the old KPI (rtrequest, >>> rtrequest1, >> >> do you really want to do the extra work instructions? >> > ... >>> >>> The defines will not give you a stable KPI and having that changed again >>> if you are going with a prefix for each AF would be a pain if the >>> _fib versions >>> are going to change in the future. >> >> hmm fair enough... but let me outline my plans and thoughts >> so we can see if you still want this.. >> > [ ... ] >> >> This all however is not ABI compatible so could not go back to 7.x >> and I want to check in an initial version that can go back to 7.x >> which sort of suggests to me that adding in_xxx functions is >> not really required, until I do the next step. >> 7.x will never get the next step. because the ABI is already set >> in stone for 7.x. >> >> I would make the in_xxx stubs in the next step in 8.x. >> after the MFC to 7.x of the ABI compat version. >> >> >> let me know what you think. > > Leaving aside any upcoming enhancement if what we have now is > what is going into 7 and possibly 6 we should do the wrapper > functions. > > The point is RELENG_7 will live for $(last release + 2 years) so I > guess till 2011 or maybe later. No idea what would happen there in all > that time. > > If people start adding support for other AFs we cannot say that the > *_fib variants are not going to change so having the in_* stable > sounds like a good thing for 6 and 7. > > Am I missing anything obvious? > > > I don't mind if they are going to significantly change again in 8 > a few weeks later. ok, check http://www.freebsd.org/~julian/mrt.diff > > > /bz >