From owner-svn-src-head@freebsd.org Sun Mar 12 03:06:04 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3EBC6D077EC; Sun, 12 Mar 2017 03:06:04 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0AEB316D2; Sun, 12 Mar 2017 03:06:04 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x241.google.com with SMTP id o126so15215137pfb.1; Sat, 11 Mar 2017 19:06:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=F0tXN0X0Vix+nsuZE+19QpZX91o9by88OSeSnomhVSg=; b=SPOZJPJMWfJrcr7yS8dee1MRo7q0EqUcK/b7i9FsL1tbvBjbUrV614LlLWVhlzf2ur F1H+Lf1dOPosjhMypsSiqJcyjsTQNG0/OMMR3ZfSfyD4fpq3ImEdJFmSEijs8agwbYiO GbzF6ZyDEqZAdHqAiYCOCVWOcpPZcs30kRcGQulICtkcwykPA3wuzqnnQH5IHEU6hE2X H9fYr4f0d/8GlFzCrCHsPFWIhiM4JYZrT7kCDmwip4y75jDBDRoLlLmb5GpWVU6MAN6G 8vAawAoGS/lkJatLvc9wvJjpNFb5A9lVcUxGugqBOqBgsOme9iLpJA2XlS0Ey8SL+PGM 3KpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=F0tXN0X0Vix+nsuZE+19QpZX91o9by88OSeSnomhVSg=; b=HbNJzhRjvaTDXK8kL+B5hWLc+UkXMCctPn6L7QmSeDpzwTNgO3BbFX+SLvCE+h07fT bi2uHBtNJnjApnwfJAqayAw19E3VwiOjowOQDUVMh850EaL8RyVutejMMYeTWVbvodkN Tad0aFJEH2trqGF+ZSdd3dfTVn7o0Q37XvCEuyQ/V/uUurQAPjIgxovpUEY8dLdLtVPF 0JuLgj+N2CjFboDeXUdWbaRJ5wIMjgM8nJ2i35PUAgwGgD+w4To/8pS+6yuSRbOlQGjy 8T+SQhmDtKkOmr7Chx8e/XxFpX+YekspuDq8Zoky9i6/zo1F0EIz4TeMFom5UyqkCAv9 Yz+g== X-Gm-Message-State: AMke39kRT8rwa0LNpjpp5Zxxy7U883msw+K5mRStKW0gomXXjvXKwjN/unDESAvp/Md9Bg== X-Received: by 10.99.8.4 with SMTP id 4mr29161891pgi.204.1489287963472; Sat, 11 Mar 2017 19:06:03 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id i15sm26344019pfj.0.2017.03.11.19.06.02 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 11 Mar 2017 19:06:02 -0800 (PST) Subject: Re: svn commit: r315091 - head/share/termcap Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_9AB7A29B-FDE6-4B97-9B25-B4218B992969"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <1489287453.40576.75.camel@freebsd.org> Date: Sat, 11 Mar 2017 19:06:02 -0800 Cc: "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <0EAE6C58-4573-4A71-97C8-0D672C814945@gmail.com> References: <201703120037.v2C0bjdq045397@repo.freebsd.org> <1489287453.40576.75.camel@freebsd.org> To: Ian Lepore X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Mar 2017 03:06:04 -0000 --Apple-Mail=_9AB7A29B-FDE6-4B97-9B25-B4218B992969 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 11, 2017, at 18:57, Ian Lepore wrote: =E2=80=A6 > In an arm build sandbox I ran "make distribution DESTDIR=3D/tmp/ian" = and > this is what happened with termcap: >=20 > --- etc-termcap --- > install -l rs /usr/share/misc/termcap /tmp/ian/etc/termcap > ... > revolution > file /tmp/ian/etc/termcap > /tmp/ian/etc/termcap: symbolic link to = ../../../usr/share/misc/termcap >=20 >=20 > Then I changed the rsymlink in share/termcap/Makefile to: >=20 > ${INSTALL_RSYMLINK} ${DESTDIR}/${BINDIR}/misc/termcap = ${DESTDIR}/etc/termcap >=20 > and it did the right thing: >=20 > --- etc-termcap --- > install -l rs /tmp/ian//usr/share/misc/termcap /tmp/ian/etc/termcap > ... > revolution > file /tmp/ian/etc/termcap > /tmp/ian/etc/termcap: symbolic link to ../usr/share/misc/termcap >=20 >=20 > I haven't thought hard about whether adding DESTDIR like that would > always fix the problem the right way. DESTDIR !=3D =E2=80=9C=E2=80=9D is the key point to triggering = the bug that was causing the failures I noted in my other email (it has = nothing to do with arm specifically). Rod=E2=80=99s code will only work = for DESTDIR =3D=3D =E2=80=9C=E2=80=9D. Thanks, -Ngie --Apple-Mail=_9AB7A29B-FDE6-4B97-9B25-B4218B992969 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYxLsaAAoJEPWDqSZpMIYVNq4P/15F2TXTjynMO/EZAx2NGUDi 1ARd6dynMGxR+5uuiU910Rj010SyA6lodRAanZ4wLDNiXsTHbhf5smWGuIie/8yV rUss5AzUDS9dCHvCis3eOOm9F8uR48q712VBIvCiq9lhZhS2uzfSvsmQFsdVnTff VRwkGs/UrQ11ur30nePHqZLY+VThjHl03VvoNcnjrILbhi2EHSr9ArDPjSEx4Z0R i4rsh8nm8ckRWmtrCwCfVfV9tQCp3hK1GTEYXxXq1FdLmtgiTO/2kWF7Nutk4ZH1 HnvI/p8c4ty1gheo86Duu46UKH/KHn6L+qRahl1xdvoFAbWqrjEYUEABB/jKucqo +mBQT0VAhn6fDDs28Atm4ZtCJli83vsBI/1pD2BxuZTVwjXkc3MdALK+oel1cpsB WZcvTaNnbEcx5/trD2tDHK1fMZG2N+8pFTuLc0CeG/BFKcVIDnxKgkMukW4hEs0C JFdqqipAb3JiypzfYJXa+LOOuRzqwJZAYPxdiJvoCQ5R1VBywuTLwV8DcrA8R3nK eD5w3GfKaXCff8+DBQDaGOYPqWEkQYIU/qZ1JKdUHivty7WX/UDasfxt8qlIJeA6 RriNeOizPPSNI+UnlnzKpf2IMZ/b0v3TJ+BPFyMhpovpnBpYw0TVYXT2Mi37MMo+ YOyUwG7ZD1SUAE5O9Aen =Rh+E -----END PGP SIGNATURE----- --Apple-Mail=_9AB7A29B-FDE6-4B97-9B25-B4218B992969--