Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 09 Dec 2013 15:05:21 -0800
From:      Navdeep Parhar <np@FreeBSD.org>
To:        Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org,  svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r259143 - head/usr.sbin/bsdinstall/scripts
Message-ID:  <52A64CB1.4060201@FreeBSD.org>
In-Reply-To: <201312092256.rB9MuJ1i027962@svn.freebsd.org>
References:  <201312092256.rB9MuJ1i027962@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12/09/13 14:56, Eitan Adler wrote:
> Author: eadler
> Date: Mon Dec  9 22:56:19 2013
> New Revision: 259143
> URL: http://svnweb.freebsd.org/changeset/base/259143
> 
> Log:
>   sed(1): Use /i instead of /I
>   
>   	the i modifier was added in r259132 since POSIX recently agreed to add
>   	it. Switch uses of /I to /i.

There doesn't seem to be any upside to this sort of change.  The
downside obviously is that it won't work with older sed's that don't
understand /i.

If you are considering sweeping over the entire tree looking for sed
invocations and "fixing" them then please reconsider.

Regards,
Navdeep


> 
> Modified:
>   head/usr.sbin/bsdinstall/scripts/services
> 
> Modified: head/usr.sbin/bsdinstall/scripts/services
> ==============================================================================
> --- head/usr.sbin/bsdinstall/scripts/services	Mon Dec  9 22:40:22 2013	(r259142)
> +++ head/usr.sbin/bsdinstall/scripts/services	Mon Dec  9 22:56:19 2013	(r259143)
> @@ -29,7 +29,7 @@
>  : ${DIALOG_OK=0}
>  
>  if [ -f $BSDINSTALL_TMPETC/rc.conf.services ]; then
> -	eval `sed -e s/YES/on/I -e s/NO/off/I $BSDINSTALL_TMPETC/rc.conf.services`
> +	eval `sed -e s/YES/on/i -e s/NO/off/i $BSDINSTALL_TMPETC/rc.conf.services`
>  else
>  	# Default service states. Everything is off if not enabled.
>  	sshd_enable="on"
> 




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52A64CB1.4060201>