From owner-freebsd-hackers@FreeBSD.ORG  Sat Jan  6 18:34:17 2007
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A42D816A415;
	Sat,  6 Jan 2007 18:34:17 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 634B213C469;
	Sat,  6 Jan 2007 18:34:17 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l06IXax0085038;
	Sat, 6 Jan 2007 11:33:36 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Sat, 06 Jan 2007 11:33:48 -0700 (MST)
Message-Id: <20070106.113348.353676879.imp@bsdimp.com>
To: olli@lurza.secnetix.de
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200701052106.l05L60a6042599@lurza.secnetix.de>
References: <200701041459.18321.jhb@freebsd.org>
	<200701052106.l05L60a6042599@lurza.secnetix.de>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Sat, 06 Jan 2007 11:33:36 -0700 (MST)
Cc: erik.udo@gmail.com, freebsd-hackers@freebsd.org, dougb@freebsd.org
Subject: Re: Init.c, making it chroot
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Jan 2007 18:34:17 -0000

this patch looks good, however, one nit:

In message: <200701052106.l05L60a6042599@lurza.secnetix.de>
            Oliver Fromme <olli@lurza.secnetix.de> writes:
: +		if (stat("/dev", &stst) != 0)
: +			warning("Can't stat /dev: %m");
: +		else {
: +			if (stst.st_dev == root_devno)
: +				devfs++;
: +		}

is more succinctly expressed as:

+		if (stat("/dev", &stst) != 0)
+			warning("Can't stat /dev: %m");
+		else if (stst.st_dev == root_devno)
+				devfs++;

Also, kenv(KENV_GET, ... is used a lot.  Maybe it makes sense to have
a simple kenvget call.  Would make a few lines a little shorter if
nothing else.

Otherwise, I think this is a great patch.  I don't see other problems
with it.

Warner