From owner-svn-src-vendor@freebsd.org Thu Feb 22 06:57:10 2018 Return-Path: Delivered-To: svn-src-vendor@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3333F08EA7; Thu, 22 Feb 2018 06:57:09 +0000 (UTC) (envelope-from tsoome@me.com) Received: from st13p35im-asmtp002.me.com (st13p35im-asmtp002.me.com [17.164.199.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8EEBD702C7; Thu, 22 Feb 2018 06:57:09 +0000 (UTC) (envelope-from tsoome@me.com) Received: from process-dkim-sign-daemon.st13p35im-asmtp002.me.com by st13p35im-asmtp002.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) id <0P4J00D00EYFNE00@st13p35im-asmtp002.me.com>; Thu, 22 Feb 2018 05:56:20 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=04042017; t=1519278980; bh=SFohAlVngPoNg11ANPeb5yykEhOc1jAensrflQ3beWY=; h=From:Message-id:Content-type:MIME-version:Subject:Date:To; b=F7O3M1jUG+lPmkG7l+8sUkT0cJHjcQkS5EZ5b/bKGvWR3wXFq5JrGRlZkQ+jgS+FJ qyl9fjo9TOCeDTsFOKtPnWO9mMg0DesuV3DIG9OmF6cMCtqgu0CISINgNverXYxzGY n/KjSeF6JEABgqdT3tcd6iAlX7ndzwQHHdbd5bYQAnXhP/6dbEBE4+tgVBkO2RlQXK pdqq+SJRP3fvAPeJEjx2yh52kip6RxwVTHfbjP9eCUJdWfMSnXUYp42HjsYLvop7XA JXkwTY4uDnZDNObGdS5Z+Vp4wWMWJ0H0Ar3N4p/fI6G835B9H8JyfiW5lh6jlV5ZfU lv+lPdPLj/FYQ== Received: from icloud.com ([127.0.0.1]) by st13p35im-asmtp002.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) with ESMTPSA id <0P4J00OSCF5SDY10@st13p35im-asmtp002.me.com>; Thu, 22 Feb 2018 05:56:19 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-22_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1802220076 From: Toomas Soome Message-id: <14ECCB6A-7AEE-4831-AF14-6AAF79CF4102@me.com> MIME-version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: svn commit: r329770 - vendor-sys/illumos/dist/uts/common/fs/zfs/lua Date: Thu, 22 Feb 2018 07:56:16 +0200 In-reply-to: <56dda9e2-e9ea-83b9-1e54-6569d478615a@FreeBSD.org> Cc: rgrimes@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-vendor@freebsd.org To: Alexander Motin References: <201802220104.w1M14uHQ088614@pdx.rh.CN85.dnsmgr.net> <56dda9e2-e9ea-83b9-1e54-6569d478615a@FreeBSD.org> X-Mailer: Apple Mail (2.3445.5.20) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-vendor@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the vendor work area tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 06:57:10 -0000 > On 22 Feb 2018, at 05:03, Alexander Motin wrote: >=20 > On 21.02.2018 20:04, Rodney W. Grimes wrote: >> [ Charset UTF-8 unsupported, converting... ] >>> Author: mav >>> Date: Thu Feb 22 00:46:24 2018 >>> New Revision: 329770 >>> URL: https://svnweb.freebsd.org/changeset/base/329770 >>>=20 >>> Log: >>> 9035 zfs: this statement may fall through >>>=20 >>> illumos/illumos-gate@46ac8fdfc5a1f9d8240c79a6ae5b2889cbe83553 >>>=20 >>> Reviewed by: Yuri Pankov >>> Reviewed by: Andy Fiddaman >>> Reviewed by: Matthew Ahrens >>> Approved by: Dan McDonald >>> Author: Toomas Soome >>>=20 >>> Modified: >>> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c >>> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c >>> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lstrlib.c >>> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/ltable.c >>>=20 >>> Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c Thu Feb = 22 00:42:12 2018 (r329769) >>> +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c Thu Feb = 22 00:46:24 2018 (r329770) >>> @@ -677,7 +677,7 @@ static void freeobj (lua_State *L, GCObject *o) = { >>> case LUA_TUSERDATA: luaM_freemem(L, o, sizeudata(gco2u(o))); = break; >>> case LUA_TSHRSTR: >>> G(L)->strt.nuse--; >>> - /* go through */ >>> + /* FALLTHROUGH */ >>> case LUA_TLNGSTR: { >>> luaM_freemem(L, o, sizestring(gco2ts(o))); >>> break; >>>=20 >>> Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c Thu Feb = 22 00:42:12 2018 (r329769) >>> +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c Thu Feb = 22 00:46:24 2018 (r329770) >>> @@ -475,6 +475,7 @@ static int llex (LexState *ls, SemInfo *seminfo) = { >>> else if (!lisdigit(ls->current)) return '.'; >>> /* else go through */ >> ^^^^^^^^^^^^^^^^^^^^^^^ Wasnt this already marked, perhaps = in the >> wrong place with the wrong string? > As I understand GCC 7 parses comments like that to decide whether > generate warnings or not, but this informal text is out of his > understanding. >=20 >=20 Exactly. Also in some cases it is desirable to have more text than just = FALLTHROUGH, And in some cases we may just have missed the original = comment which should be removed:) rgds, toomas