From owner-svn-src-all@FreeBSD.ORG Mon Nov 3 18:46:20 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD6171065742; Mon, 3 Nov 2008 18:46:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 5B98B8FC22; Mon, 3 Nov 2008 18:46:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id mA3IjdRU091877; Mon, 3 Nov 2008 13:46:14 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Jung-uk Kim Date: Mon, 3 Nov 2008 14:45:33 -0500 User-Agent: KMail/1.9.7 References: <200811021250.mA2CoGs1038957@svn.freebsd.org> <490F21FC.1020508@FreeBSD.org> <200811031127.14928.jkim@FreeBSD.org> In-Reply-To: <200811031127.14928.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811031445.33762.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Mon, 03 Nov 2008 13:46:14 -0500 (EST) X-Virus-Scanned: ClamAV 0.93.1/8559/Mon Nov 3 11:41:26 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@freebsd.org, Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r184558 - head/sys/dev/acpica/Osd X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2008 18:46:21 -0000 On Monday 03 November 2008 11:27:13 am Jung-uk Kim wrote: > On Monday 03 November 2008 11:08 am, Alexander Motin wrote: > > Jung-uk Kim wrote: > > > On Sunday 02 November 2008 07:50 am, Alexander Motin wrote: > > >> Author: mav > > >> Date: Sun Nov 2 12:50:16 2008 > > >> New Revision: 184558 > > >> URL: http://svn.freebsd.org/changeset/base/184558 > > >> > > >> Log: > > >> As soon as we have several threads per process now, it is not > > >> correct to use process ID as ACPI thread ID. Concurrent requests > > >> with equal thread IDs broke ACPI mutexes operation causing > > >> unpredictable errors including AE_AML_MUTEX_NOT_ACQUIRED that I > > >> have seen. > > >> > > >> Use kernel thread ID instead of process ID for ACPI thread. > > > > > > Sorry but this patch is incorrect, i.e., td_tid is not unique. > > > You have to use curthread or (p_pid, td_tid) pair. > > > Unfortunately, even if you correct this problem, you also have to > > > correct ACPI_THREAD_ID definition, which is in the vendor code. > > > That's why it wasn't done yet and it is more complicated than you > > > think, i.e., ACPI-CA assumes sizeof(ACPI_THREAD_ID) == > > > sizeof(int), etc. Please see the related ACPI-CA bugs: > > > > I'm also sorry, but that is what I see: > > typedef __int32_t __lwpid_t; /* Thread ID (a.k.a. LWP) > > */ ... > > td->td_tid = alloc_unr(tid_unrhdr); > > ... > > tid_unrhdr = new_unrhdr(PID_MAX + 2, INT_MAX, &tid_lock); > > > > So what have I missed, where is the problem? Why td_tid is not > > unique and where is the size problem? > > td_tid is unique for a process, i.e., it is used to identify thread > with a same pid, if I am not totally mistaken. If you want a true > unique tid, you have to use struct thread *. No, td_tid is globally unique. -- John Baldwin