From owner-dev-commits-src-all@freebsd.org Tue Jan 5 15:54:22 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 852B84C054D for ; Tue, 5 Jan 2021 15:54:22 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D9H9p23K7z4dYP; Tue, 5 Jan 2021 15:54:22 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 105FsFYT008162; Tue, 5 Jan 2021 07:54:15 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 105FsFL7008161; Tue, 5 Jan 2021 07:54:15 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202101051554.105FsFL7008161@gndrsh.dnsmgr.net> Subject: Re: git: 2d486ba15f33 - main - pkgbase: Move bectl to the runtime package In-Reply-To: <20210104220959.fb00d9ec75b43c3ed580ae37@bidouilliste.com> To: Emmanuel Vadot Date: Tue, 5 Jan 2021 07:54:15 -0800 (PST) CC: rgrimes@freebsd.org, "Rodney W. Grimes" , Emmanuel Vadot , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4D9H9p23K7z4dYP X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 15:54:22 -0000 > On Mon, 4 Jan 2021 12:58:58 -0800 (PST) > "Rodney W. Grimes" wrote: > > > > On Mon, 4 Jan 2021 12:49:19 -0800 (PST) > > > "Rodney W. Grimes" wrote: > > > > > > > > The branch main has been updated by manu: > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=2d486ba15f3367072d631ee588192ef46687fa4b > > > > > > > > > > commit 2d486ba15f3367072d631ee588192ef46687fa4b > > > > > Author: Emmanuel Vadot > > > > > AuthorDate: 2020-12-21 15:00:02 +0000 > > > > > Commit: Emmanuel Vadot > > > > > CommitDate: 2021-01-04 15:17:12 +0000 > > > > > > > > > > pkgbase: Move bectl to the runtime package > > > > > > > > > > runtime contain what is needed to boot in single user and repair a > > > > > system, bectl could be handy to have in this situation. > > > > > > > > I would think it belongs in the zfs package, > > > > as unless you have zfs you do not need bectrl. > > > > > > There is no zfs package. > > > > I would consider that an oversight. > > I don't. We don't have a ufs package for example. My understanding of the "big idea" of pkg base is to fine grain feature install/removal, and I would consider support for things like nfs, ufs, zfs to be along those lines of fine grain. > > > > Having zfs is controlled by WITH/WITHOUT_ZFS and this is not related > > > to pkgbase. > > > > WITH/WITHOUT are compile time constructs, pkgbase is an install time > > set of tools, why can there not be a zfs pkg? > > pkgbase is just a reflection of what is built. There can be a zfs > package nothing prevent us for having one. But as said in the commit Great, then why dont we? And to your "ufs" above could that be added as well? > runtime is the package that should contain everything needed for > booting to single user and repair a system so it contain zfs related > tools (and ufs ones). I thought the runtime package was the bits you MUST have to build a running system, and nothing more. Perhaps I have misunderstood. > The idea behind runtime is that if you start upgrading and things > break just after it you have all the tools to repair an install. I would of called that the "systemrepair" package. > > > > > > > > > > > > > > > Differential Revision: https://reviews.freebsd.org/D27708 > > > > > --- > > > > > lib/libbe/Makefile | 1 + > > > > > sbin/bectl/Makefile | 1 + > > > > > 2 files changed, 2 insertions(+) > > > > > > > > > > diff --git a/lib/libbe/Makefile b/lib/libbe/Makefile > > > > > index 291e2438ee2a..d1fab41578bf 100644 > > > > > --- a/lib/libbe/Makefile > > > > > +++ b/lib/libbe/Makefile > > > > > @@ -4,6 +4,7 @@ SHLIBDIR?= /lib > > > > > > > > > > .include > > > > > > > > > > +PACKAGE= runtime > > > > > LIB= be > > > > > SHLIB_MAJOR= 1 > > > > > SHLIB_MINOR= 0 > > > > > diff --git a/sbin/bectl/Makefile b/sbin/bectl/Makefile > > > > > index 6fa84f48661d..46d43306b9ca 100644 > > > > > --- a/sbin/bectl/Makefile > > > > > +++ b/sbin/bectl/Makefile > > > > > @@ -2,6 +2,7 @@ > > > > > > > > > > .include > > > > > > > > > > +PACKAGE=runtime > > > > > PROG= bectl > > > > > MAN= bectl.8 > > > > > > > > > > > > > > > > > > -- > > > > Rod Grimes rgrimes@freebsd.org > > > > > > > > > -- > > > Emmanuel Vadot > > > > > > > -- > > Rod Grimes rgrimes@freebsd.org > > > -- > Emmanuel Vadot > -- Rod Grimes rgrimes@freebsd.org