From owner-freebsd-current Tue Jul 16 19:21:49 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46CFC37B400 for ; Tue, 16 Jul 2002 19:21:44 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id D691543E42 for ; Tue, 16 Jul 2002 19:21:43 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 26411 invoked from network); 17 Jul 2002 02:21:42 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 17 Jul 2002 02:21:42 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g6H2Lf055099; Tue, 16 Jul 2002 22:21:41 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020717115641.T3327-100000@gamplex.bde.org> Date: Tue, 16 Jul 2002 22:21:51 -0400 (EDT) From: John Baldwin To: Bruce Evans Subject: Re: /usr/src/dev/md error (?) Cc: current@FreeBSD.ORG, Dikshie , W Gerald Hicks Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 17-Jul-2002 Bruce Evans wrote: > On Tue, 16 Jul 2002, W Gerald Hicks wrote: > >> Following patch should silence it. >> ... >> Index: src/sys/dev/md/md.c >> =================================================================== >> RCS file: /home/ncvs/src/sys/dev/md/md.c,v >> retrieving revision 1.66 >> diff -u -r1.66 md.c >> --- src/sys/dev/md/md.c 24 Jun 2002 12:07:02 -0000 1.66 >> +++ src/sys/dev/md/md.c 16 Jul 2002 21:32:44 -0000 >> @@ -606,6 +606,7 @@ >> error = mdstart_swap(sc, bp); >> break; >> default: >> + error = -1; >> panic("Impossible md(type)"); >> break; >> } > > This change and the break after the panic() are bogus. panic() "never" > returns, and the compiler knows this. Unfortunately, the RESTARTABLE_PANICS > option subverts the semantics of panic(), so panic() sometimes returns. > This breaks compilation of md.c and 28 other files in NOTES. The fix > shouldn't be to disturb the usual flow of control in those 29 files. We should probably turn RESTARTABLE_PANICS off in NOTES. > Bruce -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message