From owner-freebsd-mips@FreeBSD.ORG Mon Jan 10 12:33:08 2011 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1EC8F1065672 for ; Mon, 10 Jan 2011 12:33:08 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id D57648FC0A for ; Mon, 10 Jan 2011 12:33:07 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id p0ACRA28094965 for ; Mon, 10 Jan 2011 05:27:11 -0700 (MST) (envelope-from imp@bsdimp.com) Message-ID: <4D2AFB1D.6050104@bsdimp.com> Date: Mon, 10 Jan 2011 05:27:09 -0700 From: Warner Losh User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Thunderbird/3.1.6 MIME-Version: 1.0 To: freebsd-mips@freebsd.org References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] Support for 64-bit PTEs on n64 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2011 12:33:08 -0000 On 01/09/2011 22:03, Juli Mallett wrote: > On Sun, Jan 9, 2011 at 20:51, Jayachandran C. wrote: >> Here's my initial code to support>4GB physical memory on MIPS. This >> patch adds 64 bit page table entries in n64 compilation. >> >> I would like to add this as an optional feature for n32/o32 >> compilation with 'option PHYSADDR_64_BIT' later. > This is great! Can you put the PTE-related assembly macros into an > existing header file instead of in the sources? That's the only thing > that really stands out to me. > Agreed. Too many magic constants in magic places. On question, however. The 64-bit PTEs won't get in the way when we're running 32-bit binaries on a 64-bit kernel, will they? Warner