From owner-freebsd-current@FreeBSD.ORG  Tue Aug 11 22:21:30 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 71CB2106564A
	for <current@freebsd.org>; Tue, 11 Aug 2009 22:21:30 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outD.internet-mail-service.net (outd.internet-mail-service.net
	[216.240.47.227])
	by mx1.freebsd.org (Postfix) with ESMTP id 54AEB8FC15
	for <current@freebsd.org>; Tue, 11 Aug 2009 22:21:30 +0000 (UTC)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id D33A24C09F;
	Tue, 11 Aug 2009 15:21:29 -0700 (PDT)
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38])
	by idiom.com (Postfix) with ESMTP id 9E0A62D600E;
	Tue, 11 Aug 2009 15:21:28 -0700 (PDT)
Message-ID: <4A81EEE8.5060405@elischer.org>
Date: Tue, 11 Aug 2009 15:21:28 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
MIME-Version: 1.0
To: Ed Schouten <ed@80386.nl>
References: <wp8whraago.fsf@heho.snv.jussieu.fr>	<1250004330.1773.223.camel@balrog.2hip.net>	<wpws5atixy.fsf@heho.snv.jussieu.fr>	<3c1674c90908111235m158227a3q86af8b1d7235a7a2@mail.gmail.com>
	<20090811195240.GI1292@hoeg.nl>
In-Reply-To: <20090811195240.GI1292@hoeg.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: FreeBSD Current <current@freebsd.org>, Kip Macy <kmacy@freebsd.org>,
	Robert Noland <rnoland@freebsd.org>,
	"Arno J. Klaassen" <arno@heho.snv.jussieu.fr>
Subject: Re: 8.0-BETA2: mi_startup() panic on VIA C7 diskless
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Aug 2009 22:21:30 -0000

Ed Schouten wrote:
> * Kip Macy <kmacy@freebsd.org> wrote:
>> http://people.freebsd.org/~kmacy/flowtable_boot.patch
> 
> +	if ((V_flowtable_enable == 0) || (V_flowtable_ready == 0)
> 
> should probably read:
> 
> +	if (V_flowtable_enable == 0 || V_flowtable_ready == 0)
> 
> Right?
> 


I prefer the first, with an extra closing paren.