From owner-freebsd-stable@FreeBSD.ORG  Sun Jan 16 07:39:58 2005
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8F8C216A4CE; Sun, 16 Jan 2005 07:39:58 +0000 (GMT)
Received: from dave.horsfall.org (mrdavi2.lnk.telstra.net [139.130.75.233])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5E27F43D54; Sun, 16 Jan 2005 07:39:56 +0000 (GMT)
	(envelope-from dave@horsfall.org)
Received: from localhost (dave@localhost)
	by dave.horsfall.org (8.11.4/8.11.4) with ESMTP id j0G7doT06590;
	Sun, 16 Jan 2005 18:39:50 +1100 (EST)
Date: Sun, 16 Jan 2005 18:39:49 +1100 (EST)
From: Dave Horsfall <dave@horsfall.org>
To: Jon Noack <noackjr@alumni.rice.edu>
In-Reply-To: <41EA1087.6090008@alumni.rice.edu>
Message-ID: <Pine.BSI.4.61.0501161838560.3434@dave.horsfall.org>
References: <41EA1087.6090008@alumni.rice.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: stable@freebsd.org
cc: cognet@freebsd.org
Subject: Re: bktr_core.c commit breaks building kernels on RELENG_5
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Jan 2005 07:39:58 -0000

On Sun, 16 Jan 2005, Jon Noack wrote:

> This commit broke building kernels on RELENG_5 (see tinderbox logs):
> > cognet      2005-01-16 01:01:15 UTC

Thanks; I was wondering what broke...

> I believe this change was unintended:
> > @@ -1258,7 +1258,7 @@ vbi_read(bktr_ptr_t bktr, struct uio *ui
> >  	LOCK_VBI(bktr);
> >   	while(bktr->vbisize == 0) {
> > -		if (ioflag & IO_NDELAY) {
> > +		if (ioflag & FNDELAY) {
> >  			status = EWOULDBLOCK;
> >  			goto out;
> >  		}

Yep.

-- Dave