Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Jan 2005 18:39:49 +1100 (EST)
From:      Dave Horsfall <dave@horsfall.org>
To:        Jon Noack <noackjr@alumni.rice.edu>
Cc:        cognet@freebsd.org
Subject:   Re: bktr_core.c commit breaks building kernels on RELENG_5
Message-ID:  <Pine.BSI.4.61.0501161838560.3434@dave.horsfall.org>
In-Reply-To: <41EA1087.6090008@alumni.rice.edu>
References:  <41EA1087.6090008@alumni.rice.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 16 Jan 2005, Jon Noack wrote:

> This commit broke building kernels on RELENG_5 (see tinderbox logs):
> > cognet      2005-01-16 01:01:15 UTC

Thanks; I was wondering what broke...

> I believe this change was unintended:
> > @@ -1258,7 +1258,7 @@ vbi_read(bktr_ptr_t bktr, struct uio *ui
> >  	LOCK_VBI(bktr);
> >   	while(bktr->vbisize == 0) {
> > -		if (ioflag & IO_NDELAY) {
> > +		if (ioflag & FNDELAY) {
> >  			status = EWOULDBLOCK;
> >  			goto out;
> >  		}

Yep.

-- Dave



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSI.4.61.0501161838560.3434>