From owner-svn-src-head@freebsd.org  Sun Apr 23 13:11:03 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B665D4C27A;
 Sun, 23 Apr 2017 13:11:03 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 07FB1C30;
 Sun, 23 Apr 2017 13:11:02 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v3NDAuW3034877
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sun, 23 Apr 2017 16:10:56 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v3NDAuW3034877
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id v3NDAuBC034875;
 Sun, 23 Apr 2017 16:10:56 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 23 Apr 2017 16:10:56 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Jilles Tjoelker <jilles@stack.nl>
Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r317315 - head/lib/libc/gen
Message-ID: <20170423131056.GA1622@kib.kiev.ua>
References: <201704230317.v3N3HWtd040005@repo.freebsd.org>
 <20170423095345.GC57674@kib.kiev.ua>
 <20170423130736.GA53007@stack.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170423130736.GA53007@stack.nl>
User-Agent: Mutt/1.8.2 (2017-04-18)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Apr 2017 13:11:03 -0000

On Sun, Apr 23, 2017 at 03:07:36PM +0200, Jilles Tjoelker wrote:
> On Sun, Apr 23, 2017 at 12:53:45PM +0300, Konstantin Belousov wrote:
> > On Sun, Apr 23, 2017 at 03:17:32AM +0000, Ngie Cooper wrote:
> > > Author: ngie
> > > Date: Sun Apr 23 03:17:32 2017
> > > New Revision: 317315
> > > URL: https://svnweb.freebsd.org/changeset/base/317315
> 
> > > Log:
> > >   Note that getpagesize(3) can return -1 on failure
> 
> > getpagesize() cannot fail.  This change only confuses the readers.
> 
> Although I agree that getpagesize() cannot fail and that it is
> inappropriate to check for it, the code in lib/libc/gen/getpagesize.c
> has a path where it returns -1 (if sysctl CTL_HW HW_PAGESIZE fails). It
> probably makes more sense to abort() here to avoid confusing both humans
> and static analyzers, and allow easier debugging if a bug causes it to
> fail (instead of calculating bogus sizes from the -1 return value).

If the sysctl() call fails there, I think it does not make any sense to
bother with abort(), since we do not run on a FreeBSD(-like) kernel.
Might be, it would be cleaner to change return (-1) to return (PAGE_SIZE)
in the 'error case'.