From owner-svn-src-head@freebsd.org Tue Aug 20 07:10:26 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 26BA8C8124; Tue, 20 Aug 2019 07:10:26 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46CMPs14cfz4079; Tue, 20 Aug 2019 07:10:24 +0000 (UTC) (envelope-from ohartmann@walstatt.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566285013; bh=ewWDeGVmT7vq87/C7tfztFqrh1l2tUqM2F0g7qPkJxo=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=kt5k3qdqe9LbxtV6osOKxbak3HXnkhFBpYo2w60gj4zk9XxBQUDnUnQ5gGER9OV5V oW8DIIitWUIWalKw+Rwin+2Tnt3Tkqity5ZRZp6ewjgzlkY8EcZKUjj33QO8zh9W/s qVMELCpyNkpU2l9rpqMwgZPPTdFNAbb+2iN2vciI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from freyja ([46.88.81.15]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LyR1G-1iMT8x02KM-015nzM; Tue, 20 Aug 2019 09:04:25 +0200 Date: Tue, 20 Aug 2019 09:04:23 +0200 From: "O. Hartmann" To: "Stephen J. Kiernan" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351244 - head/sys/dev/usb/net Message-ID: <20190820090413.6c08b565@freyja> In-Reply-To: <201908200106.x7K16hWT067244@repo.freebsd.org> References: <201908200106.x7K16hWT067244@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:4t2/3dEb8jAM205ipaJmRNSCtjGXiT1Tz1fqhxcFwBMQpdpZqZ7 VRjpaCvfCnDP2qJ4DwSIYIMPp1xY+u3fbw5OxA2JSkOAXH7WuTC/6h7Qu/Ao+7ysygP18eo 5hpdhO3yqXu0Ya8U7fXPB2qbXZRZuOmMYiRweIithYX053dAts5eDLn1KUi4YZy9xzhbvmL 8EVlOjepXfcvPtnGHGmYA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:YKN2WAVnpMc=:tVAjonYjndl93GLu3VST/G CdJ1j9AM5lImdU6hhsAsUC/g8V4mudERz4FaUdKQLznnF3r88JpdAqWEksYJzQmHHRHKuTPw8 5JFmoaV/UVa13RZ0t0FmlP2OvLheD7qH0Qax/7h59yLkSLYYH/V4x96dU9A3FFxBTVFta+No4 Q2ttChalV0FNG+WE1nFX1uwynDXaZkDv4Bj/BdpXszmdN67UXMGBnzInsNePQHh/GYxJqJEYG j+ghUVer4621nDTaZUcgGnoLsdamOnZeCYSsrb73GwvFjY0gWV8scufklhRmxnJUFNGZpdllj n/IF2krJD4cgLPtVi1fIG2StTe5GxZG48K67oTdyJ3osrwF4cOcXZycGOFU9DvpypuWu8NZDD MksQABeDWKhXxJbVFLHLfvTFqH4+GB0JNV2DaBbuzfIaajuhTf/HSb27m/8Gd8SVkWjxRs0ut m55oDJ1yDBqFfB/oMMJr9d+8ddgsdvTV88y6g+VvyaE/qX1WIhhdeoKXv7i1Wbx+WwmQYs2CJ VHum4KYffAZkt6LQYIbkzJES8LOg2X8GM3qwJb+EjP2ug1tGrheTZRKgFiYSj6SSOsw9rbGLl RclCIDOAfml/IwqEOcko/3J7U3kLekena42IN6Zrg7TRpvkFf8xAhePg1RKKk9yDaJuyuhdKt 6fokEKJBeorQVx5x09pq+dfmS953hTw1rd+Sqb+eZBX2DaEGxapRqkAFY4d1poXwf3Vg3nwvi wHpkQYJld6Oom8VNWb85+fvtclnfeSwtzeLlSWOcdrAdRt+vIbz1P3WeQ7vCax7fG7nkn2LXy e6h5+66aqLqpwxA14cCEVX/PUGYrJIytiGoOXpAdMunWX4pNI2xcPtYC1ng4r1kRiRKDdSF3B 1J818zvsndjxa7QO9bSdSZ6PuYa62nCiabk6PJeEkzQkWjXOlM27HLgNuARnbHG92SlbtAtkI x6ZPIeoi2WxbM7kIdYwQmkdUGKWgF4dsSvbxBC4yBR4OhaW138EZcIknVOPb5pKwL/cpWsbkg VnBfp+WKM93ILVm5Kjmr0B3bvpOnaKfNoylfEJreEdLXwQ8HzAxgEmuboPfxTRWKIrYNhwS4e 9nNF9cVgS+AsB00LWqA2WZ2mEgvOtwJBNkD61n5H4sMuMlO8aJZF8lXs7aVBov7PconiCbP0h dfjwuHpFR7v5S1NaA1Ykp2FE7xXLrR9T6sAETooEC8cFzonw== X-Rspamd-Queue-Id: 46CMPs14cfz4079 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b=kt5k3qdq; dmarc=none; spf=none (mx1.freebsd.org: domain of ohartmann@walstatt.org has no SPF policy when checking 212.227.17.20) smtp.mailfrom=ohartmann@walstatt.org X-Spamd-Result: default: False [-3.90 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmx.net:s=badeba3b8450]; RECEIVED_SPAMHAUS_PBL(0.00)[15.81.88.46.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; IP_SCORE(-1.08)[ip: (-6.31), ipnet: 212.227.0.0/16(-1.36), asn: 8560(2.25), country: DE(-0.01)]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[walstatt.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmx.net:+]; NEURAL_HAM_SHORT(-0.92)[-0.917,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[20.17.227.212.list.dnswl.org : 127.0.3.1]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Aug 2019 07:10:26 -0000 On Tue, 20 Aug 2019 01:06:43 +0000 (UTC) "Stephen J. Kiernan" wrote: > Author: stevek > Date: Tue Aug 20 01:06:43 2019 > New Revision: 351244 > URL: https://svnweb.freebsd.org/changeset/base/351244 > > Log: > usb_ethernet.h includes a number of mii headers, but only does so in > order to have struct mii_data available. However, it only really needs > a forward declaration of struct mii_data for use in pointer form for > the return type of a function prototype. > > Custom kernel configuration that have usb and fdt enabled, but no miib= us, > end up with compilation failures because miibus_if.h will not get > generated. > > Due to the above, the following changes have been made to usb_ethernet= .h: > * remove the inclusion of mii headers > * forward-declare struct mii_data > * include net/ifq.h to satify the need for complete struct ifqueue > > Reviewed by: ian > Obtained from: Juniper Networks, Inc. > Differential Revision: https://reviews.freebsd.org/D21293 > > Modified: > head/sys/dev/usb/net/usb_ethernet.h > > Modified: head/sys/dev/usb/net/usb_ethernet.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > --- head/sys/dev/usb/net/usb_ethernet.h Tue Aug 20 00:50:17 > 2019 (r351243) +++ head/sys/dev/usb/net/usb_ethernet.h Tue Aug > 20 01:06:43 2019 (r351244) @@ -45,14 +45,11 @@ > #include > #include > #include > +#include > #include > #include > > -#include "miibus_if.h" > - > -#include > -#include > - > +struct mii_data; > struct usb_ether; > struct usb_device_request; > > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" This breaks buildkernel: [...] =3D=3D=3D> usb/udl (all) Building /usr/obj/usr/src/amd64.amd64/sys/WOTAN/modules/usr/src/sys/modules/usb/udl= /udl.ko =3D=3D=3D> usb/uether (all) Building /usr/obj/usr/src/amd64.amd64/sys/WOTAN/modules/usr/src/sys/modules/usb/uet= her/uether.ko =3D=3D=3D> usb/aue (all) Building /usr/obj/usr/src/amd64.amd64/sys/WOTAN/modules/usr/src/sys/modules/usb/aue= /if_aue.o /usr/src/sys/dev/usb/net/if_aue.c:197:8: error: unknown type name 'miibus_readreg_t' static miibus_readreg_t aue_miibus_readreg; ^ /usr/src/sys/dev/usb/net/if_aue.c:198:8: error: unknown type name 'miibus_writereg_t' static miibus_writereg_t aue_miibus_writereg; ^ /usr/src/sys/dev/usb/net/if_aue.c:199:8: error: unknown type name 'miibus_statchg_t' static miibus_statchg_t aue_miibus_statchg; ^ /usr/src/sys/dev/usb/net/if_aue.c:262:2: error: use of undeclared identifi= er 'miibus_readreg_desc' DEVMETHOD(miibus_readreg, aue_miibus_readreg), ^ /usr/src/sys/sys/bus.h:751:19: note: expanded from macro 'DEVMETHOD' #define DEVMETHOD KOBJMETHOD [...] Kind regards, oh