From owner-svn-src-head@FreeBSD.ORG Mon Jun 15 04:17:03 2015 Return-Path: Delivered-To: svn-src-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AFD3BB54; Mon, 15 Jun 2015 04:17:03 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 83E5FCFC; Mon, 15 Jun 2015 04:17:03 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from jre-mbp.elischer.org (ppp121-45-248-228.lns20.per4.internode.on.net [121.45.248.228]) (authenticated bits=0) by vps1.elischer.org (8.14.9/8.14.9) with ESMTP id t5F4GvTT087132 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 14 Jun 2015 21:17:00 -0700 (PDT) (envelope-from julian@freebsd.org) Message-ID: <557E51B4.1000102@freebsd.org> Date: Mon, 15 Jun 2015 12:16:52 +0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Simon J. Gerraty" , Dimitry Andric CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284345 - in head: . bin/cat bin/chflags bin/chio bin/chmod bin/cp bin/csh bin/date bin/dd bin/df bin/domainname bin/echo bin/ed bin/expr bin/freebsd-version bin/getfacl bin/hostname bi... References: <201506131920.t5DJKwMH033508@svn.freebsd.org> <24490.1434318198@chaos> In-Reply-To: <24490.1434318198@chaos> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 04:17:03 -0000 On 6/15/15 5:43 AM, Simon J. Gerraty wrote: > Dimitry Andric wrote: >> Some questions about this commit, which I'm sure more people must have: > Sure, good questions and as you say, many likely thinking the same. > >> * Was it really necessary to commit hundreds of clearly generated files? > Short answer is "yes" - since they are actually what makes the build > work. > >> * Couldn't these be generated on the fly, or with some "make depend" like command? > The whole point is to avoid that overhead. As long as there is a REALLY EASY WAY to regenerate them and it's well documented, (preferably in each generated file) and regenerating them generates EXACTLY the same output each time unless there is a source change, (so svn doesn't see a change if there is none) then I guess having them checked in is ok. (though a bit "yucky"). I'd like the ability to make a full make however that DOES regenerate them if I feel I have the time. > >> * How to update these files, if you change anything in the 'real' Makefiles? > For now don't worry about it, those of us that want to build/play with > meta mode will take care of updating them. > > Simply building in meta mode is all that is needed to update them. > >> * Or are you now the maintainer of these .depend files? :-) > For now, yes. > I think that's the only reasonable approach at this early stage. > > Thanks > --sjg > > > >