From owner-freebsd-current@FreeBSD.ORG Wed May 12 12:16:03 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A7DC8106564A; Wed, 12 May 2010 12:16:03 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 040F58FC13; Wed, 12 May 2010 12:16:02 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o4CCGAfA048559 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 May 2010 15:16:10 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o4CCFurm055147; Wed, 12 May 2010 15:15:56 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o4CCFu2p055146; Wed, 12 May 2010 15:15:56 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 12 May 2010 15:15:56 +0300 From: Kostik Belousov To: Dag-Erling Sm??rgrav Message-ID: <20100512121556.GA83316@deviant.kiev.zoral.com.ua> References: <201005070036.o470a3pl044330@chez.mckusick.com> <86d3x24a43.fsf@ds4.des.no> <20100511193333.GW83316@deviant.kiev.zoral.com.ua> <86hbmduxzh.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bgVZo3zXaTQrZhjg" Content-Disposition: inline In-Reply-To: <86hbmduxzh.fsf@ds4.des.no> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-current@freebsd.org, Ivan Voras Subject: Re: HEADS UP: 64-bit quotas going in to head today X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 May 2010 12:16:03 -0000 --bgVZo3zXaTQrZhjg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 12, 2010 at 02:05:06PM +0200, Dag-Erling Sm??rgrav wrote: > Kostik Belousov writes: > > Dag-Erling Sm??rgrav writes: > > > It adds quite a bit of code to pretty much every UFS VOP. > > No, it does not. Essentially, it adds one or two function calls per > > vop that allocate or deallocate blocks or inodes, and the function > > bodies verify two array members and return if those are NULL. >=20 > Read ufs_vnops.c, count the number of #ifdef QUOTA. There's quite a bit > more than just "one or two function calls per vop". Quite a bit of > locking going on, too, e.g. in ufs_accessx(). I did read the code when I fine-locked quotas. I stand on my position that it is one or two accounting calls per vop that do nothing in case of disabled quotas. ufs_accessx() path is seldomly executed. You mostly have to open file read-write if you are going to modify inode, and vn_open_cred() already uses exclusive locking there. It is calls like chmod(2) that are catched at this point, performing the operation by path instead of fd. --bgVZo3zXaTQrZhjg Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkvqm/wACgkQC3+MBN1Mb4hPCwCg2q0r2r1bGjAQoUbQ9ZNGPo1L HGkAn0q4cojd53TaWHG/+7+Ixnekka2b =0qcU -----END PGP SIGNATURE----- --bgVZo3zXaTQrZhjg--