From owner-cvs-src@FreeBSD.ORG Thu Jan 10 18:32:00 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8425616A421; Thu, 10 Jan 2008 18:32:00 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail05.syd.optusnet.com.au (mail05.syd.optusnet.com.au [211.29.132.186]) by mx1.freebsd.org (Postfix) with ESMTP id F3F0913C447; Thu, 10 Jan 2008 18:31:59 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from server.vk2pj.dyndns.org (c220-239-20-82.belrs4.nsw.optusnet.com.au [220.239.20.82]) by mail05.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id m0AIUU7N017472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 11 Jan 2008 05:30:32 +1100 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.2/8.14.1) with ESMTP id m0AIUU0C060049; Fri, 11 Jan 2008 05:30:30 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.2/8.14.2/Submit) id m0AIUS73060048; Fri, 11 Jan 2008 05:30:28 +1100 (EST) (envelope-from peter) Date: Fri, 11 Jan 2008 05:30:28 +1100 From: Peter Jeremy To: Robert Watson Message-ID: <20080110183028.GT4442@server.vk2pj.dyndns.org> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com> <20080109201424.GA4969@server.vk2pj.dyndns.org> <478531AC.5030303@errno.com> <20080110085803.H66908@fledge.watson.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dc+cDN39EJAMEtIO" Content-Disposition: inline In-Reply-To: <20080110085803.H66908@fledge.watson.org> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.17 (2007-11-01) Cc: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, obrien@freebsd.org, Max Laier , Sam Leffler Subject: Re: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2008 18:32:00 -0000 --dc+cDN39EJAMEtIO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 10, 2008 at 08:59:59AM +0000, Robert Watson wrote: >In the past, we've had several subtle bugs crop up as a result of changing= =20 >to ANSI C function prototypes, which no longer automatically promote=20 >arguments to int from shorter types I hadn't considered that but it _is_ the sort of thing that comparing object files would detect - if you make a supposedly stylistic change and the generated code changes then it's time to take a much more careful look into what you are doing. > (I think it's that way around). That would be correct - I know Sun Studio 11 (at least) warns about the situation where mixing ANSI and K&R prototypes/definitions causes type mismatches due to implicit promotion. I thought gcc did as well. --=20 Peter Jeremy Please excuse any delays as the result of my ISP's inability to implement an MTA that is either RFC2821-compliant or matches their claimed behaviour. --dc+cDN39EJAMEtIO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHhmRE/opHv/APuIcRAiJCAKCKPAkSxqMlOMiISNvlshULHDK5QACgg9sv tJw5c3d6Y3BWhwqYngZFWPw= =H+UQ -----END PGP SIGNATURE----- --dc+cDN39EJAMEtIO--